-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-15983. Use jersey-json that is built to use jackson2 #3988
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
f6900e1
to
30fd735
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@aajisaka when you get a chance, could you review this? I'm not sure if the failing tests are related to the change. |
This comment was marked as outdated.
This comment was marked as outdated.
Update LICENSE-binary merge issues Update pom.xml Update pom.xml
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@aajisaka there is a still a problem with this change - see https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3988/16/artifact/out/patch-mvninstall-root.txt
The issue is this (truncated a bit):
[EDIT] I think I fixed this with 629399a |
💔 -1 overall
This message was automatically generated. |
@aajisaka @steveloughran would either of you be able to take a look at this. The test that failed is one that seems to fail regularly anyway. I think I have fixed the other issues. This change would only be targeted at a future 3.4.0 release. |
this should involve those sub projects who use jersey, to make sure they are all happy. if it was a random github artifact we'd be reluctant; the fact you are an asf member who could get code into our classpath anyway if you tried hard means this isn't an issue. would probably need an incompatible entry in the release notes for any maven project excluding/overriding the old one |
@steveloughran one option would be for me to change the package name in my variant of jersey-json so that other projects that use hadoop and jersey 1 wouldn't be affected. From looking around a bit, many other projects that use hadoop don't use jersey themselves or use jersey 2 in some cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, thank you @pjfanning for your hard work and thank you @steveloughran for reviewing and starting the discussion on the mailing list.
I want to merge this tomorrow if there is no objection.
@aajisaka thanks for reviewing this - if there are any issues post-merge, I will have a look |
Merged into trunk. Thank you @pjfanning and @steveloughran |
…pache#3988)" This reverts commit 6318708.
Moves from com.sun.jersey 1.19 to the artifact com.github.pjfanning:jersey-json:1.20 This allows jackson 1 to be removed from the classpath. Contains * HADOOP-16908. Prune Jackson 1 from the codebase and restrict its usage for future * HADOOP-18219. Fix shaded client test failure These are needed for the HADOOP-15983 changes to build. Contributed by PJ Fanning.
…3988) Moves from com.sun.jersey 1.19 to the artifact com.github.pjfanning:jersey-json:1.20 This allows jackson 1 to be removed from the classpath. Contains * HADOOP-16908. Prune Jackson 1 from the codebase and restrict its usage for future * HADOOP-18219. Fix shaded client test failure These are needed for the HADOOP-15983 changes to build. Contributed by PJ Fanning.
Moves from com.sun.jersey 1.19 to the artifact com.github.pjfanning:jersey-json:1.20 This allows jackson 1 to be removed from the classpath. Contains * HADOOP-16908. Prune Jackson 1 from the codebase and restrict its usage for future * HADOOP-18219. Fix shaded client test failure These are needed for the HADOOP-15983 changes to build. Contributed by PJ Fanning.
…core. HADOOP-15983. Use jersey-json that is built to use jackson2 (apache#3988)
…core. HADOOP-15983. Use jersey-json that is built to use jackson2 (apache#3988) (cherry picked from commit 1545e6c)
* ODP-1095 CVE Fix jettison upgrade (cherry picked from commit c4e0492) * gson upgraded to 2.9.0 (cherry picked from commit 60d566d) * ODP-1098: Upgrade jackson from 2.10.5 to 2.13.2.2 (cherry picked from commit 5eb67fd) * ODP-1099 | Upgrade jetty version to 9.4.43.v20210629 (cherry picked from commit 1ac7946) * ODP-1104 | snappy-java to 1.1.10.4, snappy-java to 1.1.10.4 (cherry picked from commit 56016fb) * ODP-1103: HADOOP-11245. Update NFS gateway to use Netty4 (apache#2832) netty - part1 (cherry picked from commit d94759b) * ODP-1103: HADOOP-15327. Upgrade MR ShuffleHandler to use Netty4 apache#3259. Contributed by Szilard Nemeth. netty - part2 (cherry picked from commit ee0f478) # Conflicts: # hadoop-project/pom.xml * ODP-1104 | update guava.version to 32.0.1-jre (cherry picked from commit d45a329) * YARN-9081. Update jackson from 1.9.13 to 2.x in hadoop-yarn-services-core. HADOOP-15983. Use jersey-json that is built to use jackson2 (apache#3988) (cherry picked from commit 1545e6c) * ODP-1119-snakeyaml dependency: upgrade to v2.0 (cherry picked from commit 4d1c080) * ODP-1098: add javax.ws.rs-api - 2.1.1 dependency YARN-11558 - Fix dependency convergence error on hbase2 profile (cherry picked from commit 5a9a65d) * ODP-1104 | mvn dependency fix for snappy-java in hadoop-yarn-server-timelineservice-hbase-tests/pom.xml (cherry picked from commit a41ad5c) * TAG change 3.2.3.3.2.2.0-1095 (cherry picked from commit 8567f12) * TAG change2 3.2.3.3.2.2.0-1095 (cherry picked from commit 61e898d) * TAG change3 3.2.3.3.2.3.0-1095 (cherry picked from commit 58d1b91) * TAG change4 3.2.3.3.2.2.0-2 (cherry picked from commit a813e1d) * ODP-1095: set hadoop version as 3.2.3.3.2.2.0-1095 (cherry picked from commit d12de04) * HADOOP-18950. Use shaded avro jar (cherry picked from commit 509824a) * ODP-1103|netty4 upgrade to 4.1.94 (cherry picked from commit 627108d) * jettison dependency exclusion from hadoop-common (cherry picked from commit 0da4db2) * zookeeper release corrected to 3.2.2.0-1095 (cherry picked from commit 4a8bebf) * excluded jackson-core-asl from hadoop-yarn-server-timelineservice-hbase-tests * distribution management addition * ODP-1103: remove netty jar from hadoop-yarn-server-timelineservice-hbase-tests * HADOOP-18512. Upgrade woodstox-core to 5.4.0 for security fix * fixed typo * HADOOP-17033. Update commons-codec from 1.11 to 1.14 * Fixed maven pom across all pom * Removing not required file --------- Co-authored-by: manishsinghmowall <manishsingh@acceldata.io> Co-authored-by: kravii <ravi@acceldata.io> Co-authored-by: Prabhjyot Singh <prabhjyot@acceldata.io>
Description of PR
Use a jersey-json fork that supports jackson 2. This jar is still a prototype. This PR is experimental and not yet for merging.
How was this patch tested?
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?