-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-16447. RBF: Registry HDFS Router's RPCServer & RPCClient metrics for PrometheusSink #3965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neilxzn
changed the title
RBF: Registry HDFS Router's rpcserver & rpcclient metrics for Prometh…
HDFS-16447. RBF: Registry HDFS Router's rpcserver & rpcclient metrics for Prometh…
Feb 8, 2022
💔 -1 overall
This message was automatically generated. |
goiri
changed the title
HDFS-16447. RBF: Registry HDFS Router's rpcserver & rpcclient metrics for Prometh…
HDFS-16447. RBF: Registry HDFS Router's RPCServer & RPCClient metrics for PrometheusSink
Feb 8, 2022
goiri
approved these changes
Feb 8, 2022
Thank you for @goiri 's review. |
Commit message misses the jira id: |
It is kind of weird as the PR had the full name. |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
https://issues.apache.org/jira/browse/HDFS-16447
When we enable PrometheusSink for HDFS Router, Router' prometheus sink miss some metrics, for example
RpcClientNumActiveConnections
and so on.We need registry some Router's rpcserver & rpcclient metrics for PrometheusSink.
How was this patch tested?
no new test
For code changes:
use
@Metric
to registry metrics.