HADOOP-17386. Change default fs.s3a.buffer.dir to be under Yarn container path on yarn applications #3908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
monthonk
force-pushed
the
HADOOP-17386-default-buffer-dir
branch
from
a7eb3a4
to
27d64c4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
monthonk
force-pushed
the
HADOOP-17386-default-buffer-dir
branch
from
27d64c4
to
f5efaa8
Compare
|
Rebased and tested in Test result |
|
💔 -1 overall
This message was automatically generated. |
aajisaka
approved these changes
Feb 16, 2022
|
Hi @steveloughran, would you review this PR? |
|
@aajisaka Thank you for your time reviewing my PR! |
…iner path on yarn applications
monthonk
force-pushed
the
HADOOP-17386-default-buffer-dir
branch
from
f5efaa8
to
456c576
Compare
|
💔 -1 overall
This message was automatically generated. |
|
It is important that HADOOP-17631 is in first, otherwise am applications running in secure mode won't get a valid path here. given that is the case on this branch, all is good here. |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…iner path on yarn applications (apache#3908) Co-authored-by: Monthon Klongklaew <monthonk@amazon.com> Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Jun 9, 2023
…iner path on yarn applications (#3908) Co-authored-by: Monthon Klongklaew <monthonk@amazon.com> Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
fs.s3a.buffer.dir defaults to hadoop.tmp.dir which is /tmp or similar. A lot of systems don't clean up /tmp until reboot -and if they stay up for a long time then they accrue files written through s3a staging committer from spark containers which fail.
Fix: use ${env.LOCAL_DIRS:-${hadoop.tmp.dir}}/s3a as the option so that if env.LOCAL_DIRS is set is used over hadoop.tmp.dir. YARN-deployed apps will use that for the buffer dir. When the app container is destroyed, so is the directory.
How was this patch tested?
Injected LOCAL_DIRS env and verified that it was picked up by S3A. Also when it is not set, verified that hadoop.tmp.dir would be used as a fallback.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?