-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-16406. ReadsFromLocalClient counts short-circuit reads #3847
Conversation
💔 -1 overall
This message was automatically generated. |
@secfree Thanks for your contribution. It looks good to me. |
@ferhui thanks for your review. The failed test case is the one you recorded HDFS-16169. And I have raised a PR for it: #3850 |
@secfree can you check the checkstyle? |
💔 -1 overall
This message was automatically generated. |
...ct/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMetrics.java
Outdated
Show resolved
Hide resolved
🎊 +1 overall
This message was automatically generated. |
@aajisaka Thanks for your review! Do you have other comments, I plan to merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. Thanks
Description of PR
How was this patch tested?
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?