Skip to content

HADOOP-18036 : Backport HADOOP-17653 for branch-3.2 #3758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: branch-3.2
Choose a base branch
from
Open

HADOOP-18036 : Backport HADOOP-17653 for branch-3.2 #3758

wants to merge 1 commit into from
+151 −7

Conversation

AnanyaSingh2121
Copy link

Do not use guava's Files.createTempDir()

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 12m 46s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 3 new or modified test files.
_ branch-3.2 Compile Tests _
+0 🆗 mvndep 3m 23s Maven dependency ordering for branch
+1 💚 mvninstall 27m 16s branch-3.2 passed
+1 💚 compile 18m 19s branch-3.2 passed
+1 💚 checkstyle 2m 52s branch-3.2 passed
+1 💚 mvnsite 3m 55s branch-3.2 passed
+1 💚 javadoc 3m 15s branch-3.2 passed
+1 💚 spotbugs 7m 28s branch-3.2 passed
+1 💚 shadedclient 16m 24s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 26s Maven dependency ordering for patch
-1 ❌ mvninstall 0m 57s /patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch failed.
-1 ❌ mvninstall 0m 37s /patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt hadoop-yarn-server-resourcemanager in the patch failed.
-1 ❌ mvninstall 0m 18s /patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-services_hadoop-yarn-services-core.txt hadoop-yarn-services-core in the patch failed.
-1 ❌ compile 2m 39s /patch-compile-root.txt root in the patch failed.
-1 ❌ javac 2m 39s /patch-compile-root.txt root in the patch failed.
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 2m 35s the patch passed
-1 ❌ mvnsite 0m 59s /patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch failed.
-1 ❌ mvnsite 0m 39s /patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt hadoop-yarn-server-resourcemanager in the patch failed.
-1 ❌ mvnsite 0m 22s /patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-services_hadoop-yarn-services-core.txt hadoop-yarn-services-core in the patch failed.
+1 💚 javadoc 2m 10s the patch passed
-1 ❌ spotbugs 0m 58s /patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch failed.
-1 ❌ spotbugs 0m 38s /patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt hadoop-yarn-server-resourcemanager in the patch failed.
-1 ❌ spotbugs 0m 21s /patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-services_hadoop-yarn-services-core.txt hadoop-yarn-services-core in the patch failed.
-1 ❌ shadedclient 5m 32s patch has errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 0m 58s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch failed.
+1 💚 unit 17m 58s hadoop-hdfs-rbf in the patch passed.
-1 ❌ unit 0m 38s /patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt hadoop-yarn-server-resourcemanager in the patch failed.
-1 ❌ unit 0m 19s /patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-services_hadoop-yarn-services-core.txt hadoop-yarn-services-core in the patch failed.
+1 💚 asflicense 0m 26s The patch does not generate ASF License warnings.
138m 50s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3758/1/artifact/out/Dockerfile
GITHUB PR #3758
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux 72d861fd8ce1 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.2 / 1bc87de
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~18.04-b10
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3758/1/testReport/
Max. process+thread count 1287 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3758/1/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

jojochuang
jojochuang reviewed Dec 22, 2021
View reviewed changes
...op-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/client/ServiceClient.java
}
}

private void addYarnSysFs(Path path,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i suspect the the change in the ServiceClient.java is totally unnecessary, because the method is not used at all.

jojochuang
jojochuang reviewed Dec 22, 2021
View reviewed changes
...g/apache/hadoop/hdfs/server/common/blockaliasmap/impl/TestInMemoryLevelDBAliasMapClient.java
import org.apache.hadoop.test.LambdaTestUtils;
import org.apache.hadoop.thirdparty.com.google.common.collect.Lists;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't compile. We didn't relocate Guava classes in 3.2.x

jojochuang
jojochuang reviewed Dec 22, 2021
View reviewed changes
.../yarn/server/resourcemanager/scheduler/fair/policies/TestDominantResourceFairnessPolicy.java
@@ -29,7 +29,7 @@
import java.util.Map;
import java.util.TreeSet;

import org.apache.curator.shaded.com.google.common.base.Joiner;
import org.apache.hadoop.thirdparty.com.google.common.base.Joiner;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't compile. the relocated guava classes do not exist in 3.2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jojochuang jojochuang jojochuang left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AnanyaSingh2121 @hadoop-yetus @jojochuang