YARN-11014. YARN incorrectly validates maximum capacity resources on … #3715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the validation API
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
9uapaw
requested changes
Nov 26, 2021
There was a problem hiding this comment.
Thank you @brumi1024 for working on this. The change is well done, I do not have objections on that part. What could be improved here I think would be a test case for a custom resource as well and see what happens in that case.
Comment on lines
+193
to
+208
| setUpMockRM(false); | ||
| RMContext rmContext = mockRM.getRMContext(); | ||
| CapacitySchedulerConfiguration oldConfiguration = cs.getConfiguration(); | ||
| CapacitySchedulerConfiguration newConfiguration = | ||
| new CapacitySchedulerConfiguration(cs.getConfiguration()); | ||
| newConfiguration.setMaximumResourceRequirement("", LEAF_A_FULL_PATH, FULL_MAXRES); | ||
| try { | ||
| CapacitySchedulerConfigValidator | ||
| .validateCSConfiguration(oldConfiguration, newConfiguration, rmContext); | ||
| fail("Parent maximum capacity exceeded"); | ||
| } catch (IOException e) { | ||
| Assert.assertTrue(e.getCause().getMessage() | ||
| .startsWith("Max resource configuration")); | ||
| } finally { | ||
| mockRM.stop(); | ||
| } |
There was a problem hiding this comment.
I am wondering whether this block could be extracted like the following:
CapacitySchedulerConfiguration newConfiguration =
new CapacitySchedulerConfiguration(cs.getConfiguration());
newConfiguration.setMaximumResourceRequirement("", LEAF_A_FULL_PATH, FULL_MAXRES);
boolean shouldFail = false;
validateCSConfig(newConfiguration, shouldFail);
|
🎊 +1 overall
This message was automatically generated. |
9uapaw
reviewed
Nov 30, 2021
There was a problem hiding this comment.
Thank you for the changes @brumi1024. I had a few feedbacks. +1 from me once they are fixed.
...oop/yarn/server/resourcemanager/scheduler/capacity/TestCapacitySchedulerConfigValidator.java
Outdated
Show resolved
Hide resolved
...oop/yarn/server/resourcemanager/scheduler/capacity/TestCapacitySchedulerConfigValidator.java
Outdated
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
9uapaw
approved these changes
Dec 1, 2021
szilard-nemeth
approved these changes
Dec 7, 2021
|
Thanks @brumi1024 for working on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…the validation API
Description of PR
How was this patch tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?