-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-17851. Support user specified content encoding for S3A #3498
Merged
steveloughran
merged 12 commits into
apache:trunk
from
steveloughran:s3/HADOOP-17851-content-encoding
Sep 29, 2021
Merged
HADOOP-17851. Support user specified content encoding for S3A #3498
steveloughran
merged 12 commits into
apache:trunk
from
steveloughran:s3/HADOOP-17851-content-encoding
Sep 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cts they are putting. This is useful for people loading the data into other tools in the AWS ecosystem which don't use file extensions to infer compression type (e.g. serving compressed files from S3 or importing into RDS)
…etup/skip is now different Change-Id: I0bec0926625667ca1c8be8fa11e8ff1a11e0dbe8
* change option to fs.s3a.object.content.encoding to line up for support of the other values * docs * dir markers do not have an encoding set * tests to verify that Change-Id: I4b042d38c9e94e7d4ffa8ee6afdc7a6c26a4c489
🎊 +1 overall
This message was automatically generated. |
steveloughran
commented
Sep 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1.
I'm happy with the final changes :)
Yay, thanks @steveloughran and everyone for their review time and help I appreciate it :) |
asfgit
pushed a commit
that referenced
this pull request
Mar 23, 2022
The option fs.s3a.object.content.encoding declares the content encoding to be set on files when they are written; this is served up in the "Content-Encoding" HTTP header when reading objects back in. This is useful for people loading the data into other tools in the AWS ecosystem which don't use file extensions to infer compression type (e.g. serving compressed files from S3 or importing into RDS) Contributed by: Holden Karau Change-Id: Ice0da75b516370f51f79e45f391d46c5c7aa4ce4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3312 by @holdenk rebased & with some final wrap-up tweaks.
I changed the key name to line up for adding the rest of the standard headers as/when we choose;
fs.object.*
would cover the set.Tested, s3 london, no s3guard. One test failure, the usual intermittent
ITestPartialRenamesDeletes.testRenameDirFailsInDelete
LICENSE
,LICENSE-binary
,NOTICE-binary
files?