Skip to content

HADOOP-17849. Exclude spotbugs-annotations from transitive dependencies on branch-3.2. #3305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

iwasakims
Copy link
Member

https://issues.apache.org/jira/browse/HADOOP-17849

Building Hadoop in dist profile with ZooKeeper 3.4.14 fails on hadoop-client-check-test-invariants. Excluding com.github.spotbugs:spotbugs-annotation from transitive dependencies should fix this for users needing zookeeer-3.4.14. Since the dependency is provided/optional on ZooKeeper 3.5.x, branch-3.3 and above are not affected.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 11m 25s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-3.2 Compile Tests _
+1 💚 mvninstall 28m 28s branch-3.2 passed
+1 💚 compile 0m 16s branch-3.2 passed
+1 💚 mvnsite 0m 19s branch-3.2 passed
+1 💚 javadoc 0m 18s branch-3.2 passed
+1 💚 shadedclient 44m 29s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 4m 58s the patch passed
+1 💚 compile 0m 13s the patch passed
+1 💚 javac 0m 13s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 0m 14s the patch passed
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+1 💚 javadoc 0m 14s the patch passed
+1 💚 shadedclient 16m 12s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 0m 14s hadoop-client-minicluster in the patch passed.
+1 💚 asflicense 0m 30s The patch does not generate ASF License warnings.
80m 17s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3305/1/artifact/out/Dockerfile
GITHUB PR #3305
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml
uname Linux 729fbbacab07 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.2 / bc401a0
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~18.04-b10
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3305/1/testReport/
Max. process+thread count 306 (vs. ulimit of 5500)
modules C: hadoop-client-modules/hadoop-client-minicluster U: hadoop-client-modules/hadoop-client-minicluster
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3305/1/console
versions git=2.17.1 maven=3.6.0
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Copy link
Member

@aajisaka aajisaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, I think it is a safe change.

@iwasakims
Copy link
Member Author

Thanks, @aajisaka. I'm merging this to branch-3.2 first.

@iwasakims iwasakims merged commit 786888b into apache:branch-3.2 Aug 16, 2021
iwasakims added a commit that referenced this pull request Aug 16, 2021
PACordonnier added a commit to TOSIT-IO/hadoop that referenced this pull request Sep 6, 2023
PACordonnier added a commit to TOSIT-IO/hadoop that referenced this pull request Oct 24, 2023
PACordonnier added a commit to TOSIT-IO/hadoop that referenced this pull request Nov 6, 2023
PACordonnier added a commit to TOSIT-IO/hadoop that referenced this pull request Nov 7, 2023
rpignolet pushed a commit to TOSIT-IO/hadoop that referenced this pull request Nov 10, 2023
Pierrotws pushed a commit to TOSIT-IO/hadoop that referenced this pull request Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants