-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-16171. De-flake testDecommissionStatus #3280
Conversation
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
d24860d
to
f27e9f2
Compare
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
@aajisaka @jojochuang This PR is an attempt to fix flakies with |
Attached this PR to an already available Jira: HDFS-12188 |
🎊 +1 overall
This message was automatically generated. |
@virajjasani Thanks for contribution.
|
Thanks @ferhui for the review.
Updated Jira title because testDecommissionStatus test is present in both
The no of under-replicated blocks on DN2 can either be 3 or 4 depending on actual blocks available in Datanode Storage. Hence, in order to make sure that once both DN1 and DN2 are decommissioned -- we have 4 under replicated blocks -- we need to first wait for total 8 blocks to be reported (including replicas) by both DNs together. This is the additional check. Once we make sure of this, we won't run in flaky test failures where sometimes due to 1 replica not being reported even before we start decommissioning, we might run into case where we can't asset all 4 blocks to be under replicated.
Good point, it doesn't solve flaky problem as of now. I just kept it while running 2 tests in parallel so that config setup is synchronized but now it is not required. I will remove it. Thanks |
ac2afda
to
84b7e45
Compare
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
FYI @ferhui @amahussein filed the Jira. How flaky is resolved? The no of under-replicated blocks on DN2 can either be 3 or 4 depending on actual blocks available in Datanode Storage. Hence, in order to make sure that once both DN1 and DN2 are decommissioned -- we have 4 under replicated blocks -- we need to first wait for total 8 blocks to be reported (including replicas) by both DNs together. This is the additional check. Once we make sure of this, we won't run in flaky test failures where sometimes due to 1 replica not being reported even before we start decommissioning, we might run into case where we can't asset all 4 blocks to be under replicated. After recent changes, haven't seen test failing in multiple test runs. Could you please take a look? |
...oop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestDecommissioningStatus.java
Show resolved
Hide resolved
...oop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestDecommissioningStatus.java
Show resolved
Hide resolved
@virajjasani Thank you for your work. Overall looks good to me. |
🎊 +1 overall
This message was automatically generated. |
Merged. Thank you @virajjasani and @ferhui |
Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
Signed-off-by: Akira Ajisaka <aajisaka@apache.org> (cherry picked from commit 6342d5e) Conflicts: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestDecommissioningStatus.java
Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
Signed-off-by: Akira Ajisaka <aajisaka@apache.org> (cherry picked from commit 6342d5e) Conflicts: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestDecommissioningStatus.java
HDFS-16171