HADOOP-17765. ABFS: Use Unique File Paths in Tests #3122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
steveloughran
requested changes
Jul 5, 2021
There was a problem hiding this comment.
If you want a unique path everywhere
UriUtils.generateUniqueTestPath() also needs to be using a URI
In which case, it can be used in these test suites. It's already picked up in all the FS contract tests. Note how it uses the forkID, so in parallel runs you always get a different path.
| blockBlob.uploadText(""); | ||
|
|
||
| FileStatus[] fileStatuses = fs.listStatus(new Path("/test/10/")); | ||
| System.out.println(new Path(String.format("%s/10/", testPath))); |
| @@ -106,7 +106,7 @@ public ITestCustomerProvidedKey() throws Exception { | |||
| @Test | |||
| public void testReadWithCPK() throws Exception { | |||
| final AzureBlobFileSystem fs = getAbfs(true); | |||
| String fileName = path("/" + methodName.getMethodName()).toString(); | |||
| String fileName = "/" + methodName.getMethodName(); | |||
There was a problem hiding this comment.
so this moves away from path(). why?
There was a problem hiding this comment.
This is an older PR, will be abandoning this. The current PR is at #3153
Could you please review that instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of ABFS driver tests use common names for file paths (e.g., "/testfile"). This poses a risk of errors during parallel test runs when static variables (such as those for monitoring stats) affected by file paths are introduced.
Using unique test file names will avoid possible errors arising from shared resources during parallel runs.