-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-17765. ABFS: Use Unique File Paths in Tests #3122
Conversation
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want a unique path everywhere
UriUtils.generateUniqueTestPath()
also needs to be using a URI
In which case, it can be used in these test suites. It's already picked up in all the FS contract tests. Note how it uses the forkID, so in parallel runs you always get a different path.
blockBlob.uploadText(""); | ||
|
||
FileStatus[] fileStatuses = fs.listStatus(new Path("/test/10/")); | ||
System.out.println(new Path(String.format("%s/10/", testPath))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use SLF4J logger
@@ -106,7 +106,7 @@ public ITestCustomerProvidedKey() throws Exception { | |||
@Test | |||
public void testReadWithCPK() throws Exception { | |||
final AzureBlobFileSystem fs = getAbfs(true); | |||
String fileName = path("/" + methodName.getMethodName()).toString(); | |||
String fileName = "/" + methodName.getMethodName(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so this moves away from path(). why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an older PR, will be abandoning this. The current PR is at #3153
Could you please review that instead?
Many of ABFS driver tests use common names for file paths (e.g., "/testfile"). This poses a risk of errors during parallel test runs when static variables (such as those for monitoring stats) affected by file paths are introduced.
Using unique test file names will avoid possible errors arising from shared resources during parallel runs.