Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-17705. S3A to add Config to set AWS region #3020

Merged
merged 5 commits into from
May 24, 2021

Conversation

mehakmeet
Copy link
Contributor

Tested by: mvn clean verify -Dparallel-tests -Dscale
Region: ap-south-1

Test:

[INFO] Results:
[INFO]
[WARNING] Tests run: 537, Failures: 0, Errors: 0, Skipped: 5
[INFO] Results:
[INFO]
[WARNING] Tests run: 1430, Failures: 0, Errors: 0, Skipped: 462
[INFO]
[ERROR] Tests run: 151, Failures: 2, Errors: 1, Skipped: 28

Timeout and intermittent failures.

CC: @steveloughran @mukund-thakur

Copy link
Contributor

@mukund-thakur mukund-thakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix those yetus failures.

@mukund-thakur
Copy link
Contributor

LGTM, will wait for yetus to become green.

@mukund-thakur
Copy link
Contributor

mukund-thakur commented May 19, 2021

+1 pending docs.

@steveloughran
Copy link
Contributor

in docs, if we have a stack trace of the error message you get before this patch is in, add it to the troubleshooting doc with a reference to the option as well

@steveloughran
Copy link
Contributor

LGTM; just need to strip out the EOLs for a merge from the web UI.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 46s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 markdownlint 0m 0s markdownlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 40m 39s trunk passed
+1 💚 compile 0m 53s trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 compile 0m 41s trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 checkstyle 0m 31s trunk passed
+1 💚 mvnsite 0m 54s trunk passed
+1 💚 javadoc 0m 27s trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 0m 36s trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 spotbugs 1m 24s trunk passed
+1 💚 shadedclient 19m 4s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 41s the patch passed
+1 💚 compile 0m 44s the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javac 0m 44s the patch passed
+1 💚 compile 0m 33s the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 javac 0m 33s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 21s the patch passed
+1 💚 mvnsite 0m 42s the patch passed
+1 💚 javadoc 0m 17s the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 0m 26s the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 spotbugs 1m 24s the patch passed
+1 💚 shadedclient 18m 35s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 2m 17s hadoop-aws in the patch passed.
+1 💚 asflicense 0m 35s The patch does not generate ASF License warnings.
93m 32s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3020/5/artifact/out/Dockerfile
GITHUB PR #3020
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell markdownlint
uname Linux 971e4df3b925 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 224910a
Default Java Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3020/5/testReport/
Max. process+thread count 706 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3020/5/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@apache apache deleted a comment from hadoop-yetus May 24, 2021
@apache apache deleted a comment from hadoop-yetus May 24, 2021
@apache apache deleted a comment from hadoop-yetus May 24, 2021
@apache apache deleted a comment from hadoop-yetus May 24, 2021
@steveloughran steveloughran merged commit 5f40003 into apache:trunk May 24, 2021
@steveloughran
Copy link
Contributor

merged to trunk, backporting if the new test runs OK there

asfgit pushed a commit that referenced this pull request May 24, 2021
The option `fs.s3a.endpoint.region` can be used
to explicitly set the AWS region of a bucket.

This is needed when using AWS Private Link, as
the region cannot be automatically determined.

Contributed by Mehakmeet Singh

Change-Id: I4b52f85d7af0ddd56b2b0505ac0124d4fcc67ca0
kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021
The option `fs.s3a.endpoint.region` can be used
to explicitly set the AWS region of a bucket.

This is needed when using AWS Private Link, as
the region cannot be automatically determined.

Contributed by Mehakmeet Singh
SimonYang-CS pushed a commit to SimonYang-CS/hadoop that referenced this pull request Dec 16, 2021
The option `fs.s3a.endpoint.region` can be used
to explicitly set the AWS region of a bucket.

This is needed when using AWS Private Link, as
the region cannot be automatically determined.

Contributed by Mehakmeet Singh
SimonYang-CS pushed a commit to SimonYang-CS/hadoop that referenced this pull request Dec 24, 2021
The option `fs.s3a.endpoint.region` can be used
to explicitly set the AWS region of a bucket.

This is needed when using AWS Private Link, as
the region cannot be automatically determined.

Contributed by Mehakmeet Singh
jojochuang pushed a commit to jojochuang/hadoop that referenced this pull request May 23, 2023
…#3020)

The option `fs.s3a.endpoint.region` can be used
to explicitly set the AWS region of a bucket.

This is needed when using AWS Private Link, as
the region cannot be automatically determined.

Contributed by Mehakmeet Singh

Change-Id: If9b1b1d8ea3556ed4dfb2d164a8a6fa477dfc36d
(cherry picked from commit 27d27beb319bcbee7d89514b6cd7ba88e325019b)
jojochuang pushed a commit to jojochuang/hadoop that referenced this pull request May 23, 2023
jojochuang pushed a commit to jojochuang/hadoop that referenced this pull request May 23, 2023
…#3020)

The option `fs.s3a.endpoint.region` can be used
to explicitly set the AWS region of a bucket.

This is needed when using AWS Private Link, as
the region cannot be automatically determined.

Contributed by Mehakmeet Singh

*Important*
This has proven to be a fairly brittle change. Consult the CDPD-26441 JIRA for details.
Test environments with the AWS CLI or run in EC2 do not pick up regressions, so
it is unlikely that test runs will identify major issues which surfaced in production.

When backported it MUST be accompanied by:

CDPD-27264. HADOOP-17771. S3AFS creation fails "Unable to find a region via the region provider chain."

This patch depends on CDPD-21205, which breaks the HBoss build/test.
Read the instructions there when cherrypicking.

Change-Id: If9b1b1d8ea3556ed4dfb2d164a8a6fa477dfc36d
jojochuang pushed a commit to jojochuang/hadoop that referenced this pull request May 23, 2023
…on via the region provider chain." (apache#3133)

This addresses the regression in Hadoop 3.3.1 where if no S3 endpoint
is set in fs.s3a.endpoint, S3A filesystem creation may fail on
non-EC2 deployments, depending on the local host environment setup.

* If fs.s3a.endpoint is empty/null, and fs.s3a.endpoint.region
  is null, the region is set to "us-east-1".
* If fs.s3a.endpoint.region is explicitly set to "" then the client
  falls back to the SDK region resolution chain; this works on EC2
* Details in troubleshooting.md, including a workaround for Hadoop-3.3.1+
* Also contains some minor restructuring of troubleshooting.md
* uses pre-Auditing LogExactlyOnce import, so doesn't depend on that patch.

Contributed by Steve Loughran.

This is a critical follow on patch to
CDPD-26441. HADOOP-17705. S3A to add Config to set AWS region (apache#3020)

Both patches must be included

Change-Id: Icca928e1752423d68591508c360ff6434997fb64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants