Skip to content

YARN-10778. Bump handlebars from 3.0.7 to 4.7.7 in /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp #2996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 11, 2021

Bumps handlebars from 3.0.7 to 3.0.8.

Changelog

Sourced from handlebars's changelog.

v3.0.8 - February 23rd, 2020

Bugfixes:

  • backport some (but not all) of the security fixes from 4.x - 156061e

Compatibility notes:

  • The properties __proto__, __defineGetter__, __defineSetter__ and __lookupGetter__ have been added to the list of "dangerous properties". If a property by that name is found and not an own-property of its parent, it will silently evaluate to undefined. This is done in both the compiled template and the "lookup"-helper. This will prevent Remote-Code-Execution exploits that have been published in npm advisories 1324 and 1316.
  • The check for dangerous properties has been changed from "propertyIsEnumerable" to "hasOwnProperty", as it is now done in Handlebars 4.6.0 and later.

Security issues resolved:

Commits

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels May 11, 2021
@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 22s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 mvninstall 38m 14s trunk passed
+1 💚 shadedclient 56m 26s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 12s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 shadedclient 17m 47s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 31s The patch does not generate ASF License warnings.
78m 14s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2996/1/artifact/out/Dockerfile
GITHUB PR #2996
Optional Tests dupname asflicense shadedclient codespell
uname Linux 424689aa33e4 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / dcfebfa
Max. process+thread count 575 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2996/1/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Copy link

@shuzirra shuzirra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The best would be to get rid of handlebars altogether. This bump removes 2 High severity vulnerability, so it is an improvement, but 2 still remains, and 5 medium as well.
https://snyk.io/test/npm/handlebars/3.0.8

Currently handlebars 4.7.7 has no known issues, but I don't know if it too much of a jump, but if we can bump to 4.7.7 I'd suggest that.

dependabot bot and others added 2 commits May 19, 2021 11:21
Change-Id: I71988509f2171a1a4fcd31bd04dec2c63a177c73
@jojochuang jojochuang force-pushed the dependabot/npm_and_yarn/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/handlebars-3.0.8 branch from dcfebfa to 0a8c198 Compare May 19, 2021 03:23
@jojochuang jojochuang changed the title Bump handlebars from 3.0.7 to 3.0.8 in /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp YARN-10778. Bump handlebars from 3.0.7 to 4.7.7 in /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp May 19, 2021
@jojochuang
Copy link
Contributor

Updated to 4.7.7. @shuzirra could you review?

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 2s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 mvninstall 34m 15s trunk passed
+1 💚 shadedclient 50m 20s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 11s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 shadedclient 15m 35s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 29s The patch does not generate ASF License warnings.
69m 21s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2996/2/artifact/out/Dockerfile
GITHUB PR #2996
Optional Tests dupname asflicense shadedclient codespell
uname Linux ebf905864b5f 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 0a8c198
Max. process+thread count 519 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2996/2/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants