YARN-9279. Remove the old hamlet package. #2986

aajisaka · 2021-05-06T23:33:22Z

Remove the old hamlet package that is not actually used since HADOOP-11875 (3.0.0-beta1).

aajisaka · 2021-05-12T02:08:53Z

The precommit check took longer than 20 hours and it aborted. I'll revert the root level change to reduce the builds.

hadoop-yetus · 2021-05-12T03:55:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	20m 7s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 3 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	34m 5s		trunk passed
+1 💚	compile	0m 45s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	0m 42s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	checkstyle	0m 35s		trunk passed
+1 💚	mvnsite	0m 45s		trunk passed
+1 💚	javadoc	0m 37s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 54s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	1m 53s		trunk passed
+1 💚	shadedclient	17m 25s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 35s		the patch passed
+1 💚	compile	0m 38s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	0m 38s		the patch passed
+1 💚	compile	0m 31s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	javac	0m 31s		hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~~20.04-b10 with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~~20.04-b10 generated 0 new + 21 unchanged - 25 fixed = 21 total (was 46)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 23s		hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: The patch generated 0 new + 0 unchanged - 552 fixed = 0 total (was 552)
+1 💚	mvnsite	0m 36s		the patch passed
+1 💚	xml	0m 1s		The patch has no ill-formed XML file.
+1 💚	javadoc	0m 34s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 34s		hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~~20.04-b10 with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~~20.04-b10 generated 0 new + 268 unchanged - 4259 fixed = 268 total (was 4527)
+1 💚	spotbugs	1m 39s		the patch passed
+1 💚	shadedclient	16m 56s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	4m 22s		hadoop-yarn-common in the patch passed.
+1 💚	asflicense	0m 28s		The patch does not generate ASF License warnings.
		104m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2986/3/artifact/out/Dockerfile
GITHUB PR	#2986
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml spotbugs checkstyle
uname	Linux 9a58f0579a8f 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `3e64394`
Default Java	Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2986/3/testReport/
Max. process+thread count	593 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2986/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

tasanuma · 2021-05-20T08:56:49Z

@aajisaka Thanks for your work. Seems we don't have any unit tests for hamlet2. Is it possible to migrate the hamlet unit tests to hamlet2?

aajisaka · 2021-05-21T01:08:10Z

Thank you @tasanuma for your review. I think it is possible. I'll update the patch.

tasanuma · 2021-05-21T02:04:48Z

Thanks for updating it, @aajisaka. +1, pending Jenkins.

hadoop-yetus · 2021-05-21T03:09:48Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 58s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 6 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	34m 57s		trunk passed
+1 💚	compile	0m 46s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	0m 45s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	checkstyle	0m 35s		trunk passed
+1 💚	mvnsite	0m 47s		trunk passed
+1 💚	javadoc	0m 38s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 55s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	2m 1s		trunk passed
+1 💚	shadedclient	17m 44s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 37s		the patch passed
+1 💚	compile	0m 42s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	0m 42s		the patch passed
+1 💚	compile	0m 36s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	javac	0m 36s		hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~~20.04-b10 with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~~20.04-b10 generated 0 new + 21 unchanged - 25 fixed = 21 total (was 46)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 24s		hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: The patch generated 0 new + 1 unchanged - 551 fixed = 1 total (was 552)
+1 💚	mvnsite	0m 36s		the patch passed
+1 💚	xml	0m 1s		The patch has no ill-formed XML file.
+1 💚	javadoc	0m 36s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 39s		hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~~20.04-b10 with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~~20.04-b10 generated 0 new + 268 unchanged - 4259 fixed = 268 total (was 4527)
+1 💚	spotbugs	1m 46s		the patch passed
+1 💚	shadedclient	17m 41s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	4m 40s		hadoop-yarn-common in the patch passed.
+1 💚	asflicense	0m 32s		The patch does not generate ASF License warnings.
		88m 17s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2986/4/artifact/out/Dockerfile
GITHUB PR	#2986
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml spotbugs checkstyle
uname	Linux b5df78662426 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `a1e619c`
Default Java	Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2986/4/testReport/
Max. process+thread count	600 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2986/4/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

tasanuma · 2021-05-21T03:41:33Z

Merged to trunk. Thank you for working on this for a long time, @aajisaka!

Signed-off-by: Takanobu Asanuma <tasanuma@apache.org>

YARN-9279. Remove the old hamlet package.

3e64394

aajisaka force-pushed the YARN-9279 branch from 57e8d27 to 3e64394 Compare May 12, 2021 02:09

aajisaka requested a review from tasanuma May 20, 2021 07:28

Migrate the hamlet tests

a1e619c

tasanuma approved these changes May 21, 2021

View reviewed changes

tasanuma merged commit c807381 into apache:trunk May 21, 2021

aajisaka deleted the YARN-9279 branch May 21, 2021 04:05

kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021

YARN-9279. Remove the old hamlet package. (apache#2986)

0794d68

Signed-off-by: Takanobu Asanuma <tasanuma@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

YARN-9279. Remove the old hamlet package. #2986

YARN-9279. Remove the old hamlet package. #2986

Uh oh!

aajisaka commented May 6, 2021

Uh oh!

aajisaka commented May 12, 2021

Uh oh!

hadoop-yetus commented May 12, 2021

Uh oh!

tasanuma commented May 20, 2021

Uh oh!

aajisaka commented May 21, 2021

Uh oh!

tasanuma commented May 21, 2021

Uh oh!

hadoop-yetus commented May 21, 2021

Uh oh!

tasanuma commented May 21, 2021

Uh oh!

Uh oh!

YARN-9279. Remove the old hamlet package. #2986

YARN-9279. Remove the old hamlet package. #2986

Uh oh!

Conversation

aajisaka commented May 6, 2021

Uh oh!

aajisaka commented May 12, 2021

Uh oh!

hadoop-yetus commented May 12, 2021

Uh oh!

tasanuma commented May 20, 2021

Uh oh!

aajisaka commented May 21, 2021

Uh oh!

tasanuma commented May 21, 2021

Uh oh!

hadoop-yetus commented May 21, 2021

Uh oh!

tasanuma commented May 21, 2021

Uh oh!

Uh oh!