HDFS-15974. RBF: Unable to display the datanode UI of the router #2915

zhuxiangyi · 2021-04-16T02:59:43Z

hadoop-yetus · 2021-04-16T04:49:45Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 4s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	37m 12s		trunk passed
+1 💚	compile	0m 38s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	0m 32s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	checkstyle	0m 26s		trunk passed
+1 💚	mvnsite	0m 38s		trunk passed
+1 💚	javadoc	0m 37s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	0m 53s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	1m 19s		trunk passed
+1 💚	shadedclient	17m 15s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 32s		the patch passed
+1 💚	compile	0m 33s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	0m 33s		the patch passed
+1 💚	compile	0m 27s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	0m 27s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 16s		the patch passed
+1 💚	mvnsite	0m 33s		the patch passed
+1 💚	javadoc	0m 30s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	0m 44s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	1m 18s		the patch passed
+1 💚	shadedclient	16m 43s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	24m 26s		hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	0m 31s		The patch does not generate ASF License warnings.
		108m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2915/1/artifact/out/Dockerfile
GITHUB PR	#2915
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 353cd971acbe 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `51b6759`
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2915/1/testReport/
Max. process+thread count	1900 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2915/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

goiri · 2021-04-16T15:39:33Z

...-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/NamenodeBeanMetrics.java

@@ -855,7 +855,7 @@ public long getNumberOfSnapshottableDirs() {

  @Override
  public String getEnteringMaintenanceNodes() {
-    return "N/A";
+    return null;


Can we add a test?
I don't think we can reproduce the JSON parsing in the browser side but let's do something closer.

Thanks for your review @goiri , I think returning "{}" is more friendly than "null". I submitted new code and added tests.

hadoop-yetus · 2021-04-20T05:53:33Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 39s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	36m 8s		trunk passed
+1 💚	compile	0m 41s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	0m 36s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	checkstyle	0m 28s		trunk passed
+1 💚	mvnsite	0m 42s		trunk passed
+1 💚	javadoc	0m 40s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	0m 56s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	1m 15s		trunk passed
+1 💚	shadedclient	14m 20s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 32s		the patch passed
+1 💚	compile	0m 32s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	0m 32s		the patch passed
+1 💚	compile	0m 28s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	0m 28s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 17s		the patch passed
+1 💚	mvnsite	0m 31s		the patch passed
+1 💚	javadoc	0m 31s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	0m 48s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	1m 15s		the patch passed
+1 💚	shadedclient	14m 14s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	17m 46s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt	hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	0m 34s		The patch does not generate ASF License warnings.
		95m 34s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.federation.router.TestRouterRpcMultiDestination

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2915/2/artifact/out/Dockerfile
GITHUB PR	#2915
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 8a84274adc84 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `1ac78a8`
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2915/2/testReport/
Max. process+thread count	2352 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2915/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

tasanuma · 2021-04-20T14:33:15Z

Nice catch, @zhuxiangyi. It seems this bug became open after HDFS-15358.

tasanuma · 2021-04-22T03:23:43Z

@goiri Could you review it again?

tasanuma · 2021-04-23T01:20:01Z

Merged. Thanks for your contribution, @zhuxiangyi. Thanks for your reviews, @goiri.

zhuxiangyi · 2021-04-23T01:33:04Z

Merged. Thanks for your contribution, @zhuxiangyi. Thanks for your reviews, @goiri.

Thanks a lot, @goiri @tasanuma .

Co-authored-by: zhuxiangyi <zhuxiangyi@360.cn> Reviewed-by: Inigo Goiri <inigoiri@apache.org> Signed-off-by: Takanobu Asanuma <tasanuma@apache.org> (cherry picked from commit dff95c5)

…che#2915) Co-authored-by: zhuxiangyi <zhuxiangyi@360.cn> Reviewed-by: Inigo Goiri <inigoiri@apache.org> Signed-off-by: Takanobu Asanuma <tasanuma@apache.org>

Fix RBF does not display datanode UI

51b6759

zhuxiangyi changed the title ~~Fix RBF does not display datanode UI~~ HDFS-15974.Fix RBF does not display datanode UI Apr 16, 2021

zhuxiangyi changed the title ~~HDFS-15974.Fix RBF does not display datanode UI~~ HDFS-15974. Fix RBF does not display datanode UI Apr 16, 2021

goiri reviewed Apr 16, 2021

View reviewed changes

goiri changed the title ~~HDFS-15974. Fix RBF does not display datanode UI~~ HDFS-15974. RBF: Unable to display the datanode UI of the router Apr 16, 2021

return to empty set and add test

1ac78a8

tasanuma approved these changes Apr 20, 2021

View reviewed changes

goiri approved these changes Apr 22, 2021

View reviewed changes

tasanuma merged commit dff95c5 into apache:trunk Apr 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HDFS-15974. RBF: Unable to display the datanode UI of the router #2915

HDFS-15974. RBF: Unable to display the datanode UI of the router #2915

Uh oh!

zhuxiangyi commented Apr 16, 2021

Uh oh!

hadoop-yetus commented Apr 16, 2021

Uh oh!

goiri Apr 16, 2021

Uh oh!

zhuxiangyi Apr 20, 2021

Uh oh!

hadoop-yetus commented Apr 20, 2021

Uh oh!

tasanuma commented Apr 20, 2021

Uh oh!

tasanuma commented Apr 22, 2021

Uh oh!

tasanuma commented Apr 23, 2021

Uh oh!

zhuxiangyi commented Apr 23, 2021

Uh oh!

Uh oh!

HDFS-15974. RBF: Unable to display the datanode UI of the router #2915

HDFS-15974. RBF: Unable to display the datanode UI of the router #2915

Uh oh!

Conversation

zhuxiangyi commented Apr 16, 2021

Uh oh!

hadoop-yetus commented Apr 16, 2021

Uh oh!

goiri Apr 16, 2021

Choose a reason for hiding this comment

Uh oh!

zhuxiangyi Apr 20, 2021

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented Apr 20, 2021

Uh oh!

tasanuma commented Apr 20, 2021

Uh oh!

tasanuma commented Apr 22, 2021

Uh oh!

tasanuma commented Apr 23, 2021

Uh oh!

zhuxiangyi commented Apr 23, 2021

Uh oh!

Uh oh!