Skip to content

HDFS-15940. Fixing and refactoring tests specific to Block recovery. #2902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 15, 2021
Merged

HDFS-15940. Fixing and refactoring tests specific to Block recovery. #2902

merged 4 commits into from
Apr 15, 2021

Conversation

jojochuang
Copy link
Contributor

HDFS-15940 for branch-3.2

virajjasani and others added 3 commits April 13, 2021 16:14
@virajjasani @jojochuang
HDFS-15940. Fixing and refactoring tests specific to Block recovery.(a…
226d5b4 
…pache#2844). Contributed by Viraj Jasani

Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
Signed-off-by: Takanobu Asanuma <tasanuma@apache.org>
(cherry picked from commit 2b5fd34)

 Conflicts:
	hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBlockRecovery.java
@virajjasani @jojochuang
HDFS-15940. Fix TestBlockRecovery2#testRaceBetweenReplicaRecoveryAndF…
70dcd81 
…inalizeBlock (ADDENDUM) (apache#2874)

(cherry picked from commit 56bd968)
(cherry picked from commit 4994b73)
@jojochuang
Fix code conflicts.
7edf24d
virajjasani
virajjasani approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 (non-binding), pending QA

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 15m 37s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 3 new or modified test files.
_ branch-3.2 Compile Tests _
+1 💚 mvninstall 34m 48s branch-3.2 passed
+1 💚 compile 1m 12s branch-3.2 passed
+1 💚 checkstyle 0m 50s branch-3.2 passed
+1 💚 mvnsite 1m 26s branch-3.2 passed
+1 💚 javadoc 1m 6s branch-3.2 passed
+1 💚 spotbugs 3m 57s branch-3.2 passed
+1 💚 shadedclient 19m 49s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 25s the patch passed
+1 💚 compile 1m 6s the patch passed
+1 💚 javac 1m 6s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 0m 47s /results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 56 unchanged - 7 fixed = 59 total (was 63)
+1 💚 mvnsite 1m 16s the patch passed
+1 💚 javadoc 0m 59s the patch passed
+1 💚 spotbugs 3m 41s the patch passed
+1 💚 shadedclient 19m 41s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 191m 46s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch failed.
+1 💚 asflicense 0m 35s The patch does not generate ASF License warnings.
296m 5s
Reason Tests
Failed junit tests hadoop.hdfs.server.namenode.TestFsck
hadoop.hdfs.server.namenode.TestEditLogRace
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2902/1/artifact/out/Dockerfile
GITHUB PR #2902
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux ad55042679bc 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.2 / 7edf24d
Default Java Private Build-1.8.0_282-8u282-b08-0ubuntu1~18.04-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2902/1/testReport/
Max. process+thread count 2135 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2902/1/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@ferhui
Copy link
Contributor

ferhui commented Apr 14, 2021

@jojochuang Thanks.
Failed tests passed locally
There are some unused imports in TestBlockRecovery.java

@jojochuang
Remove unused imports.
3c8ee87 
Change-Id: Ia8e3ab091b342ee9c6071d3aa058ce793dc8c0df
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 4s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 3 new or modified test files.
_ branch-3.2 Compile Tests _
+1 💚 mvninstall 30m 27s branch-3.2 passed
+1 💚 compile 1m 1s branch-3.2 passed
+1 💚 checkstyle 0m 46s branch-3.2 passed
+1 💚 mvnsite 1m 9s branch-3.2 passed
+1 💚 javadoc 0m 56s branch-3.2 passed
+1 💚 spotbugs 2m 53s branch-3.2 passed
+1 💚 shadedclient 16m 11s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 6s the patch passed
+1 💚 compile 0m 55s the patch passed
+1 💚 javac 0m 55s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 40s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 56 unchanged - 7 fixed = 56 total (was 63)
+1 💚 mvnsite 1m 1s the patch passed
+1 💚 javadoc 0m 46s the patch passed
+1 💚 spotbugs 3m 1s the patch passed
+1 💚 shadedclient 17m 32s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 192m 23s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch failed.
+1 💚 asflicense 0m 36s The patch does not generate ASF License warnings.
269m 55s
Reason Tests
Failed junit tests hadoop.hdfs.server.namenode.TestRedudantBlocks
hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
hadoop.hdfs.server.namenode.TestEditLogRace
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2902/2/artifact/out/Dockerfile
GITHUB PR #2902
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux 82eff6c5936f 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.2 / 3c8ee87
Default Java Private Build-1.8.0_282-8u282-b08-0ubuntu1~18.04-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2902/2/testReport/
Max. process+thread count 2364 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2902/2/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

ferhui
ferhui approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@ferhui ferhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ferhui
Copy link
Contributor

ferhui commented Apr 15, 2021

@jojochuang Thanks for this PR. @virajjasani Thanks for review!
merged

@ferhui ferhui merged commit f033182 into apache:branch-3.2 Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferhui ferhui ferhui approved these changes

@virajjasani virajjasani virajjasani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jojochuang @hadoop-yetus @ferhui @virajjasani