-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-17569. Building native code fails on Fedora 33. #2886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💔 -1 overall
This message was automatically generated. |
cc warnings are not related to the patch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you @iwasakims
Thanks, @aajisaka. I merged this. |
(cherry picked from commit 2717203)
(cherry picked from commit 2717203)
(cherry picked from commit 2717203)
https://issues.apache.org/jira/browse/HADOOP-17569
strerror
of glibc >= 2.32 is thread safe. We can just use it. We still need existing code for supporting old glibc.https://sourceware.org/pipermail/libc-announce/2020/000029.html
In addition, I added
-fcommon
to CFLAGS for building code of hadoop-hdfs-native-client since-fno-common
(default from GCC 10.0) break the build.https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85678