HDFS-15717. Improve fsck logging. #2529

amahussein · 2020-12-07T19:30:08Z

Fsck always logs success and logs blockid checks as "/".
Thanks @kihwal for providing the fix.

hadoop-yetus · 2020-12-07T23:09:15Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 30s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚		0m 0s	test4tests	The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	33m 1s		trunk passed
+1 💚	compile	1m 19s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	compile	1m 16s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	checkstyle	0m 55s		trunk passed
+1 💚	mvnsite	1m 19s		trunk passed
+1 💚	shadedclient	17m 54s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 55s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javadoc	1m 25s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+0 🆗	spotbugs	3m 6s		Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	3m 3s		trunk passed
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 13s		the patch passed
+1 💚	compile	1m 23s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javac	1m 23s		the patch passed
+1 💚	compile	1m 5s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	javac	1m 5s		the patch passed
-0 ⚠️	checkstyle	0m 43s	/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 270 unchanged - 1 fixed = 271 total (was 271)
+1 💚	mvnsite	1m 9s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	15m 17s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 54s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javadoc	1m 24s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	findbugs	3m 50s		the patch passed
			_ Other Tests _
-1 ❌	unit	126m 39s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 40s		The patch does not generate ASF License warnings.
		217m 57s

Reason	Tests
Failed junit tests	hadoop.hdfs.TestBlockTokenWrappingQOP
	hadoop.hdfs.TestStateAlignmentContextWithHA
	hadoop.hdfs.TestBlockStoragePolicy
	hadoop.hdfs.TestHDFSFileSystemContract
	hadoop.hdfs.server.balancer.TestBalancer
	hadoop.hdfs.TestDFSStartupVersions
	hadoop.hdfs.TestSetrepIncreasing
	hadoop.hdfs.TestDFSInotifyEventInputStream
	hadoop.hdfs.TestDatanodeReport
	hadoop.hdfs.TestDistributedFileSystemWithECFileWithRandomECPolicy
	hadoop.hdfs.TestReadStripedFileWithDNFailure
	hadoop.hdfs.server.namenode.TestFsck
	hadoop.hdfs.TestWriteReadStripedFile
	hadoop.hdfs.TestClientProtocolForPipelineRecovery
	hadoop.hdfs.TestLeaseRecoveryStriped
	hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy
	hadoop.hdfs.TestDecommission
	hadoop.hdfs.web.TestWebHdfsWithRestCsrfPreventionFilter
	hadoop.hdfs.TestRollingUpgradeRollback
	hadoop.hdfs.TestErasureCodingPolicies
	hadoop.hdfs.web.TestWebHDFS
	hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy
	hadoop.hdfs.TestDFSStripedOutputStreamWithFailure

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2529/1/artifact/out/Dockerfile
GITHUB PR	#2529
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux c1f11aea771b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `da1ea25`
Default Java	Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2529/1/testReport/
Max. process+thread count	4027 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2529/1/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2020-12-08T03:23:42Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 30s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚		0m 0s	test4tests	The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	32m 34s		trunk passed
+1 💚	compile	1m 20s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	compile	1m 12s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	checkstyle	0m 54s		trunk passed
+1 💚	mvnsite	1m 20s		trunk passed
+1 💚	shadedclient	17m 27s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 56s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javadoc	1m 29s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+0 🆗	spotbugs	3m 5s		Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	3m 1s		trunk passed
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 15s		the patch passed
+1 💚	compile	1m 10s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javac	1m 10s		the patch passed
+1 💚	compile	1m 6s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	javac	1m 6s		the patch passed
+1 💚	checkstyle	0m 44s		hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 270 unchanged - 1 fixed = 270 total (was 271)
+1 💚	mvnsite	1m 12s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	15m 0s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 49s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javadoc	1m 22s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	findbugs	3m 2s		the patch passed
			_ Other Tests _
-1 ❌	unit	97m 49s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 43s		The patch does not generate ASF License warnings.
		187m 2s

Reason	Tests
Failed junit tests	hadoop.hdfs.TestDFSStripedOutputStreamWithRandomECPolicy
	hadoop.hdfs.TestRollingUpgrade
	hadoop.hdfs.server.datanode.TestBlockScanner
	hadoop.hdfs.TestDecommissionWithStriped
	hadoop.hdfs.TestFileChecksumCompositeCrc
	hadoop.hdfs.TestDFSInotifyEventInputStreamKerberized

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2529/2/artifact/out/Dockerfile
GITHUB PR	#2529
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 0027ea038624 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `40f7543`
Default Java	Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2529/2/testReport/
Max. process+thread count	4326 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2529/2/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

jbrennan333

+1 this looks good to me. It matches what we have been running with internally for a few years.

…nd Ahmed Hussein (cherry picked from commit be35fa1)

…nd Ahmed Hussein

…nd Ahmed Hussein (cherry picked from commit be35fa1) Conflicts: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java

… Lee and Ahmed Hussein (cherry picked from commit be35fa1)

… Lee and Ahmed Hussein Ref: CDPD-21421 (cherry picked from commit be35fa1) Conflicts: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java (cherry picked from commit 640d8a1) Conflicts: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java Change-Id: I542ff861791c5aae2ebbcd8bda5c43ef225d8f6a (cherry picked from commit 61e2360)

HDFS-15717. Improve fsck logging.

44a7a28

amahussein force-pushed the hdfs-15717 branch from 8ddd069 to 44a7a28 Compare December 8, 2020 00:15

jbrennan333 approved these changes Dec 11, 2020

View reviewed changes

jbrennan333 merged commit be35fa1 into apache:trunk Dec 11, 2020

asfgit pushed a commit that referenced this pull request Dec 11, 2020

HDFS-15717. Improve fsck logging. (#2529) Contributed by Kihwal Lee a…

16ca8b7

…nd Ahmed Hussein (cherry picked from commit be35fa1)

asfgit pushed a commit that referenced this pull request Dec 11, 2020

HDFS-15717. Improve fsck logging. (#2529) Contributed by Kihwal Lee a…

eec10a0

…nd Ahmed Hussein

aajisaka pushed a commit to aajisaka/hadoop that referenced this pull request Jan 14, 2021

HDFS-15717. Improve fsck logging. (apache#2529) Contributed by Kihwal…

03ad110

… Lee and Ahmed Hussein (cherry picked from commit be35fa1)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HDFS-15717. Improve fsck logging. #2529

HDFS-15717. Improve fsck logging. #2529

Uh oh!

amahussein commented Dec 7, 2020

Uh oh!

hadoop-yetus commented Dec 7, 2020

Uh oh!

hadoop-yetus commented Dec 8, 2020

Uh oh!

jbrennan333 left a comment

Uh oh!

Uh oh!

HDFS-15717. Improve fsck logging. #2529

HDFS-15717. Improve fsck logging. #2529

Uh oh!

Conversation

amahussein commented Dec 7, 2020

Uh oh!

hadoop-yetus commented Dec 7, 2020

Uh oh!

hadoop-yetus commented Dec 8, 2020

Uh oh!

jbrennan333 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!