Skip to content

HADOOP-16961. ABFS: Adding metrics to AbfsInputStream #1946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

HADOOP-16961. ABFS: Adding metrics to AbfsInputStream #1946

wants to merge 1 commit into from

Conversation

bgaborg
Copy link

@bgaborg bgaborg commented Apr 8, 2020

Change-Id: I034b771533b8314364a3762034439e323758ee09

HADOOP-16961. ABFS: Adding metrics to AbfsInputStream
7c9cf1e 
Change-Id: I034b771533b8314364a3762034439e323758ee09
@bgaborg bgaborg requested a review from steveloughran April 8, 2020 15:30
steveloughran
steveloughran requested changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@steveloughran steveloughran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing?

...tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStream.java
AbfsInputStream.class);

/** Stream statistics. */
private final AbfsInputStreamStatisticsImpl streamStatistics;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interface rather than impl?

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 24m 46s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 20m 36s trunk passed
+1 💚 compile 0m 29s trunk passed
+1 💚 checkstyle 0m 22s trunk passed
+1 💚 mvnsite 0m 31s trunk passed
+1 💚 shadedclient 15m 30s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 24s trunk passed
+0 🆗 spotbugs 0m 52s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 0m 49s trunk passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 29s the patch passed
+1 💚 compile 0m 23s the patch passed
+1 💚 javac 0m 23s the patch passed
-0 ⚠️ checkstyle 0m 17s hadoop-tools/hadoop-azure: The patch generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0)
+1 💚 mvnsite 0m 27s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 17m 17s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 23s the patch passed
-1 ❌ findbugs 1m 9s hadoop-tools/hadoop-azure generated 7 new + 0 unchanged - 0 fixed = 7 total (was 0)
_ Other Tests _
+1 💚 unit 1m 25s hadoop-azure in the patch passed.
+1 💚 asflicense 0m 33s The patch does not generate ASF License warnings.
87m 30s
Reason Tests
FindBugs module:hadoop-tools/hadoop-azure
Increment of volatile field org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.readOperations in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.readOperationStarted(long, long) At AbfsInputStreamStatisticsImpl.java:in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.readOperationStarted(long, long) At AbfsInputStreamStatisticsImpl.java:[line 113]
Increment of volatile field org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.remoteReadOperations in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.remoteReadOperation() At AbfsInputStreamStatisticsImpl.java:in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.remoteReadOperation() At AbfsInputStreamStatisticsImpl.java:[line 118]
Increment of volatile field org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.backwardSeekOperations in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekBackwards(long) At AbfsInputStreamStatisticsImpl.java:in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekBackwards(long) At AbfsInputStreamStatisticsImpl.java:[line 47]
Increment of volatile field org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekOperations in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekBackwards(long) At AbfsInputStreamStatisticsImpl.java:in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekBackwards(long) At AbfsInputStreamStatisticsImpl.java:[line 46]
Increment of volatile field org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.forwardSeekOperations in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekForwards(long) At AbfsInputStreamStatisticsImpl.java:in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekForwards(long) At AbfsInputStreamStatisticsImpl.java:[line 60]
Increment of volatile field org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekOperations in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekForwards(long) At AbfsInputStreamStatisticsImpl.java:in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekForwards(long) At AbfsInputStreamStatisticsImpl.java:[line 59]
Increment of volatile field org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekInBuffer in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekInBuffer() At AbfsInputStreamStatisticsImpl.java:in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekInBuffer() At AbfsInputStreamStatisticsImpl.java:[line 103]
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1946/1/artifact/out/Dockerfile
GITHUB PR #1946
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 7dd8211e3a28 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 1189af4
Default Java 1.8.0_242
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-1946/1/artifact/out/diff-checkstyle-hadoop-tools_hadoop-azure.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1946/1/artifact/out/new-findbugs-hadoop-tools_hadoop-azure.html
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1946/1/testReport/
Max. process+thread count 412 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1946/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@steveloughran
Copy link
Contributor

@bgaborg, Can you wait for #1956 to go in? It's trying to get the args to the input stream under control. I hope to merge it on Tuesday Apr 20.

@steveloughran steveloughran mentioned this pull request Apr 20, 2020
Closed
@steveloughran
Copy link
Contributor

gabor, see if I've broken this building; if so rebase and resubmit. thanks

@mehakmeet mehakmeet mentioned this pull request Jun 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveloughran steveloughran steveloughran requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bgaborg @hadoop-yetus @steveloughran