Skip to content

HADOOP-16744. Fix building instruction to enable zstd. #1736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2019

Conversation

iwasakims
Copy link
Member

No description provided.

@aajisaka
Copy link
Member

aajisaka commented Dec 4, 2019

@iwasakims Thank you for your patch.
In the Dockerfile (dev-support/docker/Dockerfile), should we change libzstd1-dev to libzstd-dev (virtual package) as well?

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 30m 42s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 shadedclient 15m 25s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 whitespace 0m 1s The patch has no whitespace issues.
+1 💚 shadedclient 14m 59s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 30s The patch does not generate ASF License warnings.
63m 18s
Subsystem Report/Notes
Docker Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1736/1/artifact/out/Dockerfile
GITHUB PR #1736
Optional Tests dupname asflicense
uname Linux 8d05070a1e39 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / c48de9a
Max. process+thread count 307 (vs. ulimit of 5500)
modules C: . U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1736/1/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@iwasakims
Copy link
Member Author

In the Dockerfile (dev-support/docker/Dockerfile), should we change libzstd1-dev to libzstd-dev (virtual package) as well?

Sure. While we have the same result by using transitional package name (ibzstd1-dev), it would be better that the Dockerfile and documentation are consistent.

@iwasakims
Copy link
Member Author

The Dockerfile is based on xenial (16.04) in which libzstd-dev points to older version (0.5.1). We whould use libzstd1-dev pointing to newer version. Since libzstd1-dev is still available on bioinic (18.04) as transitional package, libzstd1-dev would be better in BUILDING.txt too. I will update the code.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 21s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 shadedclient 14m 58s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 15m 15s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 28s The patch does not generate ASF License warnings.
33m 43s
Subsystem Report/Notes
Docker Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1736/2/artifact/out/Dockerfile
GITHUB PR #1736
Optional Tests dupname asflicense
uname Linux c473327d73f5 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 682e6fd
Max. process+thread count 306 (vs. ulimit of 5500)
modules C: . U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1736/2/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@aajisaka
Copy link
Member

aajisaka commented Dec 6, 2019

+1, make sense. Thank you @iwasakims

@iwasakims iwasakims merged commit 18059ac into apache:trunk Dec 6, 2019
@iwasakims
Copy link
Member Author

Thanks, @aajisaka .

asfgit pushed a commit that referenced this pull request Dec 6, 2019
asfgit pushed a commit that referenced this pull request Dec 6, 2019
RogPodge pushed a commit to RogPodge/hadoop that referenced this pull request Mar 25, 2020
bentito pushed a commit to bentito/hadoop that referenced this pull request Dec 2, 2020
bentito pushed a commit to bentito/hadoop that referenced this pull request Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants