Skip to content

HDDS-2239. Fix TestOzoneFsHAUrls #1600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 7, 2019
Merged

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Make sure context classloader is restored to avoid NPE during shutdown.

https://issues.apache.org/jira/browse/HDDS-2239

How was this patch tested?

Ran TestOzoneFsHAUrls in IDE.

@adoroszlai
Copy link
Contributor Author

/label ozone

@elek elek added the ozone label Oct 4, 2019
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 40 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
-1 mvninstall 37 hadoop-hdds in trunk failed.
-1 mvninstall 38 hadoop-ozone in trunk failed.
-1 compile 21 hadoop-hdds in trunk failed.
-1 compile 14 hadoop-ozone in trunk failed.
+1 checkstyle 61 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 1066 branch has no errors when building and testing our client artifacts.
-1 javadoc 21 hadoop-hdds in trunk failed.
-1 javadoc 18 hadoop-ozone in trunk failed.
0 spotbugs 1167 Used deprecated FindBugs config; considering switching to SpotBugs.
-1 findbugs 37 hadoop-hdds in trunk failed.
-1 findbugs 20 hadoop-ozone in trunk failed.
_ Patch Compile Tests _
-1 mvninstall 34 hadoop-hdds in the patch failed.
-1 mvninstall 43 hadoop-ozone in the patch failed.
-1 compile 25 hadoop-hdds in the patch failed.
-1 compile 18 hadoop-ozone in the patch failed.
-1 javac 25 hadoop-hdds in the patch failed.
-1 javac 18 hadoop-ozone in the patch failed.
-0 checkstyle 33 hadoop-ozone: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 871 patch has no errors when building and testing our client artifacts.
-1 javadoc 23 hadoop-hdds in the patch failed.
-1 javadoc 20 hadoop-ozone in the patch failed.
-1 findbugs 34 hadoop-hdds in the patch failed.
-1 findbugs 19 hadoop-ozone in the patch failed.
_ Other Tests _
-1 unit 29 hadoop-hdds in the patch failed.
-1 unit 28 hadoop-ozone in the patch failed.
+1 asflicense 36 The patch does not generate ASF License warnings.
2747
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/1/artifact/out/Dockerfile
GITHUB PR #1600
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 40e4cb25f01b 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 10bdc59
Default Java 1.8.0_222
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/1/artifact/out/branch-mvninstall-hadoop-hdds.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/1/artifact/out/branch-mvninstall-hadoop-ozone.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/1/artifact/out/branch-compile-hadoop-hdds.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/1/artifact/out/branch-compile-hadoop-ozone.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/1/artifact/out/branch-javadoc-hadoop-hdds.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/1/artifact/out/branch-javadoc-hadoop-ozone.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/1/artifact/out/branch-findbugs-hadoop-hdds.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/1/artifact/out/branch-findbugs-hadoop-ozone.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/1/artifact/out/patch-mvninstall-hadoop-hdds.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/1/artifact/out/patch-mvninstall-hadoop-ozone.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/1/artifact/out/patch-compile-hadoop-hdds.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/1/artifact/out/patch-compile-hadoop-ozone.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/1/artifact/out/patch-compile-hadoop-hdds.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/1/artifact/out/patch-compile-hadoop-ozone.txt
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/1/artifact/out/diff-checkstyle-hadoop-ozone.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/1/artifact/out/patch-javadoc-hadoop-hdds.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/1/artifact/out/patch-javadoc-hadoop-ozone.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/1/artifact/out/patch-findbugs-hadoop-hdds.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/1/artifact/out/patch-findbugs-hadoop-ozone.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/1/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/1/testReport/
Max. process+thread count 410 (vs. ulimit of 5500)
modules C: hadoop-ozone/ozonefs U: hadoop-ozone/ozonefs
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/1/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 119 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
-1 mvninstall 57 hadoop-hdds in trunk failed.
-1 mvninstall 46 hadoop-ozone in trunk failed.
-1 compile 19 hadoop-hdds in trunk failed.
-1 compile 13 hadoop-ozone in trunk failed.
+1 checkstyle 65 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 952 branch has no errors when building and testing our client artifacts.
-1 javadoc 20 hadoop-hdds in trunk failed.
-1 javadoc 17 hadoop-ozone in trunk failed.
0 spotbugs 1044 Used deprecated FindBugs config; considering switching to SpotBugs.
-1 findbugs 33 hadoop-hdds in trunk failed.
-1 findbugs 17 hadoop-ozone in trunk failed.
_ Patch Compile Tests _
-1 mvninstall 37 hadoop-hdds in the patch failed.
-1 mvninstall 37 hadoop-ozone in the patch failed.
-1 compile 23 hadoop-hdds in the patch failed.
-1 compile 16 hadoop-ozone in the patch failed.
-1 javac 23 hadoop-hdds in the patch failed.
-1 javac 16 hadoop-ozone in the patch failed.
+1 checkstyle 59 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 824 patch has no errors when building and testing our client artifacts.
-1 javadoc 21 hadoop-hdds in the patch failed.
-1 javadoc 17 hadoop-ozone in the patch failed.
-1 findbugs 31 hadoop-hdds in the patch failed.
-1 findbugs 18 hadoop-ozone in the patch failed.
_ Other Tests _
-1 unit 28 hadoop-hdds in the patch failed.
-1 unit 23 hadoop-ozone in the patch failed.
+1 asflicense 37 The patch does not generate ASF License warnings.
2647
Subsystem Report/Notes
Docker Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/2/artifact/out/Dockerfile
GITHUB PR #1600
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux a09fa9b23a80 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 8de4374
Default Java 1.8.0_222
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/2/artifact/out/branch-mvninstall-hadoop-hdds.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/2/artifact/out/branch-mvninstall-hadoop-ozone.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/2/artifact/out/branch-compile-hadoop-hdds.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/2/artifact/out/branch-compile-hadoop-ozone.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/2/artifact/out/branch-javadoc-hadoop-hdds.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/2/artifact/out/branch-javadoc-hadoop-ozone.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/2/artifact/out/branch-findbugs-hadoop-hdds.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/2/artifact/out/branch-findbugs-hadoop-ozone.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/2/artifact/out/patch-mvninstall-hadoop-hdds.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/2/artifact/out/patch-mvninstall-hadoop-ozone.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/2/artifact/out/patch-compile-hadoop-hdds.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/2/artifact/out/patch-compile-hadoop-ozone.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/2/artifact/out/patch-compile-hadoop-hdds.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/2/artifact/out/patch-compile-hadoop-ozone.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/2/artifact/out/patch-javadoc-hadoop-hdds.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/2/artifact/out/patch-javadoc-hadoop-ozone.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/2/artifact/out/patch-findbugs-hadoop-hdds.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/2/artifact/out/patch-findbugs-hadoop-ozone.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/2/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/2/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/2/testReport/
Max. process+thread count 305 (vs. ulimit of 5500)
modules C: hadoop-ozone/ozonefs U: hadoop-ozone/ozonefs
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/2/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@adoroszlai
Copy link
Contributor Author

adoroszlai commented Oct 5, 2019

[INFO] Running org.apache.hadoop.fs.ozone.TestOzoneFsHAURLs
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 32.745 s - in org.apache.hadoop.fs.ozone.TestOzoneFsHAURLs

https://github.com/elek/ozone-ci-q4/blob/07087a6f1beec835a848cf7ee587509107334626/pr/pr-hdds-2239-t668n/integration/output.log#L2893-L2894

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 83 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
-1 mvninstall 45 hadoop-hdds in trunk failed.
-1 mvninstall 40 hadoop-ozone in trunk failed.
-1 compile 18 hadoop-hdds in trunk failed.
-1 compile 13 hadoop-ozone in trunk failed.
+1 checkstyle 59 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 944 branch has no errors when building and testing our client artifacts.
-1 javadoc 20 hadoop-hdds in trunk failed.
-1 javadoc 16 hadoop-ozone in trunk failed.
0 spotbugs 1035 Used deprecated FindBugs config; considering switching to SpotBugs.
-1 findbugs 34 hadoop-hdds in trunk failed.
-1 findbugs 17 hadoop-ozone in trunk failed.
_ Patch Compile Tests _
-1 mvninstall 31 hadoop-hdds in the patch failed.
-1 mvninstall 34 hadoop-ozone in the patch failed.
-1 compile 21 hadoop-hdds in the patch failed.
-1 compile 16 hadoop-ozone in the patch failed.
-1 javac 21 hadoop-hdds in the patch failed.
-1 javac 16 hadoop-ozone in the patch failed.
+1 checkstyle 52 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 790 patch has no errors when building and testing our client artifacts.
-1 javadoc 19 hadoop-hdds in the patch failed.
-1 javadoc 17 hadoop-ozone in the patch failed.
-1 findbugs 29 hadoop-hdds in the patch failed.
-1 findbugs 17 hadoop-ozone in the patch failed.
_ Other Tests _
-1 unit 24 hadoop-hdds in the patch failed.
-1 unit 23 hadoop-ozone in the patch failed.
+1 asflicense 29 The patch does not generate ASF License warnings.
2503
Subsystem Report/Notes
Docker Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/3/artifact/out/Dockerfile
GITHUB PR #1600
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux eac00ef72a7d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 022fe5f
Default Java 1.8.0_222
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/3/artifact/out/branch-mvninstall-hadoop-hdds.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/3/artifact/out/branch-mvninstall-hadoop-ozone.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/3/artifact/out/branch-compile-hadoop-hdds.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/3/artifact/out/branch-compile-hadoop-ozone.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/3/artifact/out/branch-javadoc-hadoop-hdds.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/3/artifact/out/branch-javadoc-hadoop-ozone.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/3/artifact/out/branch-findbugs-hadoop-hdds.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/3/artifact/out/branch-findbugs-hadoop-ozone.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/3/artifact/out/patch-mvninstall-hadoop-hdds.txt
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/3/artifact/out/patch-mvninstall-hadoop-ozone.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/3/artifact/out/patch-compile-hadoop-hdds.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/3/artifact/out/patch-compile-hadoop-ozone.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/3/artifact/out/patch-compile-hadoop-hdds.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/3/artifact/out/patch-compile-hadoop-ozone.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/3/artifact/out/patch-javadoc-hadoop-hdds.txt
javadoc https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/3/artifact/out/patch-javadoc-hadoop-ozone.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/3/artifact/out/patch-findbugs-hadoop-hdds.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/3/artifact/out/patch-findbugs-hadoop-ozone.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/3/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/3/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/3/testReport/
Max. process+thread count 305 (vs. ulimit of 5500)
modules C: hadoop-ozone/ozonefs U: hadoop-ozone/ozonefs
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1600/3/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@bharatviswa504 bharatviswa504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.
Thank You @adoroszlai for the fix and root causing this issue.
I will commit this to the trunk.

@bharatviswa504 bharatviswa504 merged commit 9685a6c into apache:trunk Oct 7, 2019
@adoroszlai adoroszlai deleted the HDDS-2239 branch October 7, 2019 17:31
@adoroszlai
Copy link
Contributor Author

Thanks @bharatviswa504 for reporting the problem, and for reviewing and committing the fix.

amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019
RogPodge pushed a commit to RogPodge/hadoop that referenced this pull request Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants