HDDS-1413. TestCloseContainerCommandHandler is flaky

[adoroszlai]

What changes were proposed in this pull request?

TestCloseContainerCommandHandler is flaky, because it uses real

1. Ratis client; 3 seconds is not always enough for the groupAdd call, resulting in timeout
2. OzoneContainer, which uses threads to collect container information, sometimes finishes only after the test is failed with NPE

The first issue might be solved by increasing the timeout to eg. 5 seconds. However, even 10+20 seconds is not always enough to avoid the second issue.

Therefore this change is a rewrite of the test cases to use mocks.

https://issues.apache.org/jira/browse/HDDS-1413

How was this patch tested?

Ran the unit test repeatedly. No other code changed.

[adoroszlai]

/label ozone

[adoroszlai]

@nandakumar131 please review

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	74	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1	mvninstall	576	trunk passed
+1	compile	380	trunk passed
+1	checkstyle	82	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	1106	branch has no errors when building and testing our client artifacts.
+1	javadoc	198	trunk passed
0	spotbugs	425	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	644	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	536	the patch passed
+1	compile	366	the patch passed
+1	javac	366	the patch passed
+1	checkstyle	74	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	744	patch has no errors when building and testing our client artifacts.
+1	javadoc	161	the patch passed
+1	findbugs	633	the patch passed
		_ Other Tests _
+1	unit	305	hadoop-hdds in the patch passed.
-1	unit	2084	hadoop-ozone in the patch failed.
+1	asflicense	44	The patch does not generate ASF License warnings.
		8159

Reason	Tests
Failed junit tests	hadoop.ozone.TestOzoneConfigurationFields
	hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
	hadoop.ozone.client.rpc.TestOzoneRpcClientForAclAuditLog

Subsystem	Report/Notes
Docker	Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1378/1/artifact/out/Dockerfile
GITHUB PR	#1378
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 2f0fb23dc22b 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 8e779a1
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1378/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1378/1/testReport/
Max. process+thread count	4994 (vs. ulimit of 5500)
modules	C: hadoop-hdds/container-service U: hadoop-hdds/container-service
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1378/1/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[anuengineer]

Thank you for your contribution. I have committed this patch to the trunk.

[adoroszlai]

Thanks @anuengineer for reviewing and committing it.