HDDS-2030. Generate simplifed reports by the dev-support/checks/*.sh scripts #1348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
requested changes
Aug 25, 2019
adoroszlai
reviewed
Aug 27, 2019
adoroszlai
reviewed
Aug 27, 2019
adoroszlai
reviewed
Aug 28, 2019
adoroszlai
reviewed
Aug 28, 2019
adoroszlai
reviewed
Aug 28, 2019
adoroszlai
approved these changes
Aug 29, 2019
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @elek for all the improvements.
adoroszlai
reviewed
Aug 30, 2019
Contributor
There was a problem hiding this comment.
Suggested change
| TEST_OUTPUT_LOCATION="${TEST_RESULT_LOCATION//.txt/-output.txt/}" | |
| TEST_OUTPUT_LOCATION="${TEST_RESULT_LOCATION//.txt/-output.txt}" |
hadoop-yetus
reviewed
Sep 2, 2019
There was a problem hiding this comment.
shellcheck:26: note: Double quote to prevent globbing and word splitting. [SC2086]
|
💔 -1 overall
This message was automatically generated. |
adoroszlai
reviewed
Sep 11, 2019
Contributor
There was a problem hiding this comment.
Please also copy *.dumpstream, which may help finding out the cause of Corrupted STDOUT warning of forked JVM.
Suggested change
| find "." -name "*.dump" -exec cp {} "$REPORT_DIR/" \; | |
| find "." -name "*.dump" -exec cp {} "$REPORT_DIR/" \; | |
| find "." -name "*.dumpstream" -exec cp {} "$REPORT_DIR/" \; |
http://maven.apache.org/surefire/maven-surefire-plugin/faq.html#dumpfiles
Co-Authored-By: Doroszlai, Attila <6454655+adoroszlai@users.noreply.github.com>
Co-Authored-By: Doroszlai, Attila <6454655+adoroszlai@users.noreply.github.com>
Co-Authored-By: Doroszlai, Attila <6454655+adoroszlai@users.noreply.github.com>
Co-Authored-By: Doroszlai, Attila <6454655+adoroszlai@users.noreply.github.com>
Co-Authored-By: Doroszlai, Attila <6454655+adoroszlai@users.noreply.github.com>
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
+1, committed to the trunk. Thanks for the contributions, @elek and @adoroszlai |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hadoop-ozone/dev-support/checks directory contains shell scripts to execute different type of code checks (findbugs, checkstyle, etc.)
Currently the contract is very simple. Every shell script executes one (and only one) check and the shell response code is set according to the result (non-zero code if failed).
To have better reporting in the github pr build, it would be great to improve the scripts to generate simple summary files and save the relevant files for archiving.
See: https://issues.apache.org/jira/browse/HDDS-2030