HDDS-2013. Add flag gdprEnabled for BucketInfo in OzoneManager proto

[dineshchitlangia]

No description provided.

[bharatviswa504]

+1 LGTM.

[bharatviswa504]

@dineshchitlangia Just letting you know, to get CI run just post a comment /label ozone.

[dineshchitlangia]

Thanks @bharatviswa504 for review.

[elek]

We can also use the existing metadata hashmap to store these kind of data. It would make it more easy to add more features without changing the protocol later...

[dineshchitlangia]

We can also use the existing metadata hashmap to store these kind of data. It would make it more easy to add more features without changing the protocol later...

@elek That is absolutely correct. We intend to use the same for storing the symmetric encryption key info. Glad that we are on the same page even before it started!!

[elek]

Cool. But why do we add the gdprEnabled flag as a dedicated field in the protocol instead of adding a [gdprEnabled]=true metadata?

(I am not against it, just trying to understand the motivation...)

[dineshchitlangia]

Cool. But why do we add the gdprEnabled flag as a dedicated field in the protocol instead of adding a [gdprEnabled]=true metadata?
@elek Thanks for your thoughts. It makes sense to use metadata hashmap for all the properties. So, we can ignore this PR. I will update the jira to reflect the same in the summary.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	161	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1	mvninstall	825	trunk passed
+1	compile	461	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	2390	branch has no errors when building and testing our client artifacts.
		_ Patch Compile Tests _
+1	mvninstall	725	the patch passed
+1	compile	462	the patch passed
+1	cc	462	the patch passed
+1	javac	462	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	928	patch has no errors when building and testing our client artifacts.
		_ Other Tests _
+1	unit	421	hadoop-hdds in the patch passed.
-1	unit	2893	hadoop-ozone in the patch failed.
+1	asflicense	49	The patch does not generate ASF License warnings.
		8209

Reason	Tests
Failed junit tests	hadoop.ozone.container.common.statemachine.commandhandler.TestBlockDeletion
	hadoop.ozone.web.client.TestKeysRatis
	hadoop.ozone.web.TestOzoneRestWithMiniCluster
	hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
	hadoop.ozone.container.server.TestSecureContainerServer
	hadoop.ozone.web.client.TestBuckets
	hadoop.ozone.client.rpc.Test2WayCommitInRatis
	hadoop.ozone.client.rpc.TestReadRetries
	hadoop.ozone.client.rpc.TestBlockOutputStream
	hadoop.ozone.web.client.TestOzoneClient

Subsystem	Report/Notes
Docker	Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1345/1/artifact/out/Dockerfile
GITHUB PR	#1345
Optional Tests	dupname asflicense compile cc mvnsite javac unit
uname	Linux 1aa94ca967eb 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / b69ac57
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1345/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1345/1/testReport/
Max. process+thread count	3882 (vs. ulimit of 5500)
modules	C: hadoop-ozone/common U: hadoop-ozone/common
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1345/1/console
versions	git=2.7.4 maven=3.3.9
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.