-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-2024. Fix rat.sh problems #1343
Conversation
/label ozone |
@elek please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 thanks the fixes
The reported rat problems are fixed in HDDS-2023 and the run shows that the script is working well:
https://github.com/elek/ozone-ci/blob/master/pr/pr-hdds-2024-c6cxm/rat/output.log
Thanks @elek for the review and commit. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
What changes were proposed in this pull request?
Fix problems in
rat.sh
:grep: warning: recursive search of stdin
due to missing search target (which works with GNU grep, but not with some others)cat: target/rat-aggregated.txt: No such file or directory
due mismatch ofREPORT_FILE
value vs. literalREPORT_FILE
valueAlso: use
-s
test instead ofcat
(probably cheaper and safer).https://issues.apache.org/jira/browse/HDDS-2024
How was this patch tested?