HDDS-2002. Update documentation for 0.4.1 release. #1331
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoyuyao
reviewed
Aug 21, 2019
xiaoyuyao
reviewed
Aug 21, 2019
xiaoyuyao
reviewed
Aug 21, 2019
|
|
||
| ## Test/Staging | ||
|
|
||
| The `docker-compose` based approach is recommended only for local test not for multi node cluster. To use containers on a multi-node cluster we need a Container Orchestrator like Kubernetes. | ||
| The `docker-compose` based approach is recommended only for local test, not for multi node cluster. | ||
| To use containers on a multi-node cluster we need a Container Orchestrator like Kubernetes. | ||
|
|
||
| Kubernetes example files are included in the `kubernetes` folder. |
There was a problem hiding this comment.
Should we be more specific like hadoop-ozone/dist/target/ozone-*/kubernetes
There was a problem hiding this comment.
The documentation is included in the tar file where there is no target/dist. I think it's fine to use path relative to the distribution tar. We can be more specific with the kubernetes/examples directory name..
xiaoyuyao
reviewed
Aug 21, 2019
|
🎊 +1 overall
This message was automatically generated. |
xiaoyuyao
reviewed
Aug 21, 2019
xiaoyuyao
reviewed
Aug 21, 2019
| @@ -116,7 +116,7 @@ aws s3api --endpoint http://localhost:9878 create-bucket --bucket bucket1 | |||
|
|
|||
| To show the storage location of a S3 bucket, use the `ozone s3 path <bucketname>` command. | |||
|
|
|||
| ``` | |||
| ```bash | |||
| aws s3api --endpoint-url http://localhost:9878 create-bucket --bucket=bucket1 | |||
|
|
|||
| ozone s3 path bucket1 | |||
There was a problem hiding this comment.
Can you confirm the output volume name is "s3thisisakey"?
There was a problem hiding this comment.
No, it looks more like some random string:
Volume name for S3Bucket is : s3100b8cad7cf2a56f6df78f171f97a1ec
Ozone FileSystem Uri is : o3fs://bucket1.s3100b8cad7cf2a56f6df78f171f97a1ec
There was a problem hiding this comment.
I think "s3thisisakey" is just some example random value for document.
There was a problem hiding this comment.
To be more precious: the volume name is "s3" + AWS_ACCESS_KEY_ID (it's not random, but your personal id, I guess)
This examples assumes that
export AWS_ACCESS_KEY_ID=thisisakey
is set.
There was a problem hiding this comment.
But, yes, this is just an example, could be any other string. And this convention can be changed later, so we shouldn't share it in the doc IMHO.
There was a problem hiding this comment.
Actually it's some encoded form of the access key ID, which I set to any. For thisisakey it turns out to be 6c7412f65c83a118bafff79dd270186c.
xiaoyuyao
reviewed
Aug 21, 2019
xiaoyuyao
reviewed
Aug 21, 2019
xiaoyuyao
reviewed
Aug 21, 2019
xiaoyuyao
reviewed
Aug 21, 2019
There was a problem hiding this comment.
Thanks @nandakumar131 for the patch. It looks great to me overall. A few comments inline...
|
🎊 +1 overall
This message was automatically generated. |
adoroszlai
approved these changes
Aug 22, 2019
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.