-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-2002. Update documentation for 0.4.1 release. #1331
Conversation
|
||
## Test/Staging | ||
|
||
The `docker-compose` based approach is recommended only for local test not for multi node cluster. To use containers on a multi-node cluster we need a Container Orchestrator like Kubernetes. | ||
The `docker-compose` based approach is recommended only for local test, not for multi node cluster. | ||
To use containers on a multi-node cluster we need a Container Orchestrator like Kubernetes. | ||
|
||
Kubernetes example files are included in the `kubernetes` folder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be more specific like hadoop-ozone/dist/target/ozone-*/kubernetes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation is included in the tar file where there is no target/dist. I think it's fine to use path relative to the distribution tar. We can be more specific with the kubernetes/examples
directory name..
🎊 +1 overall
This message was automatically generated. |
@@ -116,7 +116,7 @@ aws s3api --endpoint http://localhost:9878 create-bucket --bucket bucket1 | |||
|
|||
To show the storage location of a S3 bucket, use the `ozone s3 path <bucketname>` command. | |||
|
|||
``` | |||
```bash | |||
aws s3api --endpoint-url http://localhost:9878 create-bucket --bucket=bucket1 | |||
|
|||
ozone s3 path bucket1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you confirm the output volume name is "s3thisisakey"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it looks more like some random string:
Volume name for S3Bucket is : s3100b8cad7cf2a56f6df78f171f97a1ec
Ozone FileSystem Uri is : o3fs://bucket1.s3100b8cad7cf2a56f6df78f171f97a1ec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "s3thisisakey" is just some example random value for document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be more precious: the volume name is "s3" + AWS_ACCESS_KEY_ID (it's not random, but your personal id, I guess)
This examples assumes that
export AWS_ACCESS_KEY_ID=thisisakey
is set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But, yes, this is just an example, could be any other string. And this convention can be changed later, so we shouldn't share it in the doc IMHO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it's some encoded form of the access key ID, which I set to any
. For thisisakey
it turns out to be 6c7412f65c83a118bafff79dd270186c
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nandakumar131 for the patch. It looks great to me overall. A few comments inline...
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
No description provided.