-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HDDS-1999. Basic acceptance test and SCM/OM web UI broken by Bootstrap upgrade #1327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/label ozone |
💔 -1 overall
This message was automatically generated. |
@vivekratnavel @elek please review |
HDDS-2000 is also related but I would like to remove the dependencies between HDFS and HDDS web pages. But we can separate the version bump (this jira) and the resource copy (HDDS-2000) |
I agree with @elek. We should have a copy of all the static dependencies inside HDDS and not depend on HDFS. |
@elek @vivekratnavel breaking the dependency is fine, but can we please get rid of the acceptance test failures? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM.
Thank You @adoroszlai for the fix.
Now acceptance test suite is passing.
I will commit this to the trunk.
Thanks @bharatviswa504 for review/commit. |
What changes were proposed in this pull request?
Update bootstrap/jquery version references in SCM/OM/S3G and in acceptance test.
https://issues.apache.org/jira/browse/HDDS-1999
How was this patch tested?
Ran
basic.robot
inozones3
compose folder.Checked SCM/OM/S3G web UI visually.