Skip to content

HDDS-1999. Basic acceptance test and SCM/OM web UI broken by Bootstrap upgrade #1327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2019

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Update bootstrap/jquery version references in SCM/OM/S3G and in acceptance test.

https://issues.apache.org/jira/browse/HDDS-1999

How was this patch tested?

Ran basic.robot in ozones3 compose folder.

Checked SCM/OM/S3G web UI visually.

@adoroszlai
Copy link
Contributor Author

/label ozone

@elek elek added the ozone label Aug 21, 2019
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 101 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
0 mvndep 68 Maven dependency ordering for branch
+1 mvninstall 635 trunk passed
+1 compile 362 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 1809 branch has no errors when building and testing our client artifacts.
+1 javadoc 164 trunk passed
_ Patch Compile Tests _
0 mvndep 28 Maven dependency ordering for patch
+1 mvninstall 576 the patch passed
+1 compile 372 the patch passed
+1 javac 372 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 663 patch has no errors when building and testing our client artifacts.
+1 javadoc 172 the patch passed
_ Other Tests _
+1 unit 292 hadoop-hdds in the patch passed.
-1 unit 1938 hadoop-ozone in the patch failed.
+1 asflicense 43 The patch does not generate ASF License warnings.
6339
Reason Tests
Failed junit tests hadoop.ozone.om.TestOzoneManagerHA
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient
hadoop.ozone.TestStorageContainerManager
hadoop.ozone.client.rpc.TestCommitWatcher
hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException
hadoop.ozone.ozShell.TestOzoneShell
hadoop.ozone.container.server.TestSecureContainerServer
hadoop.ozone.TestMiniChaosOzoneCluster
hadoop.hdds.scm.pipeline.TestSCMPipelineManager
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1327/1/artifact/out/Dockerfile
GITHUB PR #1327
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient
uname Linux 82563191e4ef 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / e684b17
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1327/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1327/1/testReport/
Max. process+thread count 3843 (vs. ulimit of 5500)
modules C: hadoop-hdds/server-scm hadoop-ozone/dist hadoop-ozone/ozone-manager hadoop-ozone/s3gateway U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1327/1/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@adoroszlai
Copy link
Contributor Author

@vivekratnavel @elek please review

@elek
Copy link
Member

elek commented Aug 21, 2019

HDDS-2000 is also related but I would like to remove the dependencies between HDFS and HDDS web pages.

But we can separate the version bump (this jira) and the resource copy (HDDS-2000)

@vivekratnavel
Copy link
Contributor

I agree with @elek. We should have a copy of all the static dependencies inside HDDS and not depend on HDFS.

@adoroszlai
Copy link
Contributor Author

@elek @vivekratnavel breaking the dependency is fine, but can we please get rid of the acceptance test failures?

Copy link
Contributor

@bharatviswa504 bharatviswa504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.
Thank You @adoroszlai for the fix.
Now acceptance test suite is passing.
I will commit this to the trunk.

@bharatviswa504 bharatviswa504 merged commit 2ae7f44 into apache:trunk Aug 21, 2019
@adoroszlai adoroszlai deleted the HDDS-1999 branch August 21, 2019 19:19
@adoroszlai
Copy link
Contributor Author

Thanks @bharatviswa504 for review/commit.

asfgit pushed a commit that referenced this pull request Aug 28, 2019
amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants