HDDS-1898. GrpcReplicationService#download cannot replicate the container. #1326

nandakumar131 · 2019-08-21T10:55:20Z

No description provided.

hadoop-yetus · 2019-08-21T13:26:45Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	42	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	64	Maven dependency ordering for branch
+1	mvninstall	646	trunk passed
+1	compile	354	trunk passed
+1	checkstyle	63	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	790	branch has no errors when building and testing our client artifacts.
+1	javadoc	145	trunk passed
0	spotbugs	443	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	638	trunk passed
		_ Patch Compile Tests _
0	mvndep	30	Maven dependency ordering for patch
+1	mvninstall	554	the patch passed
+1	compile	353	the patch passed
+1	javac	353	the patch passed
-0	checkstyle	30	hadoop-hdds: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)
-0	checkstyle	32	hadoop-ozone: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	617	patch has no errors when building and testing our client artifacts.
+1	javadoc	147	the patch passed
+1	findbugs	665	the patch passed
		_ Other Tests _
+1	unit	298	hadoop-hdds in the patch passed.
-1	unit	1493	hadoop-ozone in the patch failed.
+1	asflicense	36	The patch does not generate ASF License warnings.
		7149

Reason	Tests
Failed junit tests	hadoop.ozone.om.TestOzoneManagerHA
	hadoop.ozone.client.rpc.TestReadRetries
	hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory
	hadoop.ozone.web.client.TestKeys

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1326/1/artifact/out/Dockerfile
GITHUB PR	#1326
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux fab6e9351fb3 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `10ec31d`
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1326/1/artifact/out/diff-checkstyle-hadoop-hdds.txt
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1326/1/artifact/out/diff-checkstyle-hadoop-ozone.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1326/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1326/1/testReport/
Max. process+thread count	2803 (vs. ulimit of 5500)
modules	C: hadoop-hdds/container-service hadoop-ozone/integration-test U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1326/1/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-08-22T12:31:17Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	81	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	69	Maven dependency ordering for branch
+1	mvninstall	666	trunk passed
+1	compile	386	trunk passed
+1	checkstyle	90	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	1024	branch has no errors when building and testing our client artifacts.
+1	javadoc	185	trunk passed
0	spotbugs	464	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	685	trunk passed
		_ Patch Compile Tests _
0	mvndep	30	Maven dependency ordering for patch
+1	mvninstall	569	the patch passed
+1	compile	408	the patch passed
+1	javac	408	the patch passed
+1	checkstyle	80	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	1	The patch has no whitespace issues.
+1	shadedclient	733	patch has no errors when building and testing our client artifacts.
+1	javadoc	167	the patch passed
+1	findbugs	720	the patch passed
		_ Other Tests _
+1	unit	392	hadoop-hdds in the patch passed.
-1	unit	2312	hadoop-ozone in the patch failed.
+1	asflicense	44	The patch does not generate ASF License warnings.
		8790

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestContainerStateMachineFailures
	hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
	hadoop.ozone.container.server.TestSecureContainerServer
	hadoop.ozone.client.rpc.TestOzoneRpcClientForAclAuditLog
	hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory

Subsystem	Report/Notes
Docker	Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1326/2/artifact/out/Dockerfile
GITHUB PR	#1326
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 6d6e7b85362c 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `ee7c261`
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1326/2/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1326/2/testReport/
Max. process+thread count	4523 (vs. ulimit of 5500)
modules	C: hadoop-hdds/container-service hadoop-ozone/integration-test U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1326/2/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

nandakumar131 · 2019-08-23T16:58:49Z

/retest

hadoop-yetus · 2019-08-27T06:38:04Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	9	#1326 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem	Report/Notes
GITHUB PR	#1326
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1326/3/console
versions	git=2.17.1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

elek

LGTM

+1 after the rebase + a new jenkins run

Thanks to fix this @nandakumar131 I have seen this issue in unit tests multiple times but didn't find the root cause.

…iner.

hadoop-yetus · 2019-09-04T16:49:25Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	43	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	64	Maven dependency ordering for branch
+1	mvninstall	673	trunk passed
+1	compile	389	trunk passed
+1	checkstyle	82	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	899	branch has no errors when building and testing our client artifacts.
+1	javadoc	191	trunk passed
0	spotbugs	952	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	1236	trunk passed
		_ Patch Compile Tests _
0	mvndep	74	Maven dependency ordering for patch
+1	mvninstall	1077	the patch passed
+1	compile	564	the patch passed
+1	javac	564	the patch passed
+1	checkstyle	88	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	796	patch has no errors when building and testing our client artifacts.
+1	javadoc	179	the patch passed
+1	findbugs	667	the patch passed
		_ Other Tests _
+1	unit	279	hadoop-hdds in the patch passed.
-1	unit	1855	hadoop-ozone in the patch failed.
+1	asflicense	54	The patch does not generate ASF License warnings.
		9558

Reason	Tests
Failed junit tests	hadoop.ozone.scm.node.TestQueryNode
	hadoop.ozone.om.TestSecureOzoneManager
	hadoop.ozone.TestSecureOzoneCluster
	hadoop.ozone.container.common.statemachine.commandhandler.TestBlockDeletion

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1326/5/artifact/out/Dockerfile
GITHUB PR	#1326
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 91a8e13a5493 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `1ae7759`
Default Java	1.8.0_222
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1326/5/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1326/5/testReport/
Max. process+thread count	5200 (vs. ulimit of 5500)
modules	C: hadoop-hdds/container-service hadoop-ozone/integration-test U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1326/5/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

lokeshj1703 · 2019-09-05T05:32:11Z

@nandakumar131 Thanks for working on the PR! The changes look good to me. +1.

nandakumar131 · 2019-09-05T12:42:19Z

Failures are not related to this patch. Tested them locally.

…iner. (apache#1326)

nandakumar131 requested a review from mukul1987 August 21, 2019 10:55

nandakumar131 added the ozone label Aug 21, 2019

elek approved these changes Aug 29, 2019

View reviewed changes

nandakumar131 added 2 commits September 3, 2019 17:21

HDDS-1898. GrpcReplicationService#download cannot replicate the conta…

d911d76

…iner.

Fixed checkstyle issues.

54d80da

nandakumar131 force-pushed the HDDS-1898 branch from 1d8277d to 54d80da Compare September 3, 2019 12:02

lokeshj1703 approved these changes Sep 5, 2019

View reviewed changes

nandakumar131 merged commit 2b16d53 into apache:trunk Sep 5, 2019

nandakumar131 deleted the HDDS-1898 branch September 5, 2019 12:52

amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019

HDDS-1898. GrpcReplicationService#download cannot replicate the conta…

4228e79

…iner. (apache#1326)

RogPodge pushed a commit to RogPodge/hadoop that referenced this pull request Mar 25, 2020

HDDS-1898. GrpcReplicationService#download cannot replicate the conta…

e3ca419

…iner. (apache#1326)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HDDS-1898. GrpcReplicationService#download cannot replicate the container. #1326

HDDS-1898. GrpcReplicationService#download cannot replicate the container. #1326

Uh oh!

nandakumar131 commented Aug 21, 2019

Uh oh!

hadoop-yetus commented Aug 21, 2019

Uh oh!

hadoop-yetus commented Aug 22, 2019

Uh oh!

nandakumar131 commented Aug 23, 2019

Uh oh!

hadoop-yetus commented Aug 27, 2019

Uh oh!

elek left a comment

Uh oh!

hadoop-yetus commented Sep 4, 2019

Uh oh!

lokeshj1703 commented Sep 5, 2019

Uh oh!

nandakumar131 commented Sep 5, 2019

Uh oh!

Uh oh!

HDDS-1898. GrpcReplicationService#download cannot replicate the container. #1326

HDDS-1898. GrpcReplicationService#download cannot replicate the container. #1326

Uh oh!

Conversation

nandakumar131 commented Aug 21, 2019

Uh oh!

hadoop-yetus commented Aug 21, 2019

Uh oh!

hadoop-yetus commented Aug 22, 2019

Uh oh!

nandakumar131 commented Aug 23, 2019

Uh oh!

hadoop-yetus commented Aug 27, 2019

Uh oh!

elek left a comment

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented Sep 4, 2019

Uh oh!

lokeshj1703 commented Sep 5, 2019

Uh oh!

nandakumar131 commented Sep 5, 2019

Uh oh!

Uh oh!