HDFS-14718. HttpFS: Sort response by key names as WebHDFS does #1270
+17
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ia799ee1b242ab420c8d1de2c07efaf060f066434
goiri
requested changes
Aug 10, 2019
| Map quotaUsageMap = quotaUsageToMap(quotaUsage); | ||
| response.put(HttpFSFileSystem.QUOTA_USAGE_JSON, quotaUsageMap); | ||
| return response; | ||
| } | ||
|
|
||
| private static Map<String, Object> quotaUsageToMap(QuotaUsage quotaUsage) { | ||
| Map<String, Object> result = new LinkedHashMap<>(); | ||
| Map<String, Object> result = new TreeMap<>(); |
There was a problem hiding this comment.
It would be nice to add a unit test to make sure that the order is preserved.
There was a problem hiding this comment.
I haven't found any existing unit tests that compares the order of the response JSON of WebHDFS and HttpFS. e.g. BaseTestHttpFSWith#testQuotaUsage checks the the correctness of output from DFS/HttpFS but doesn't care about the order.
That might be something we want to do with a new unit test class. Or is there one test class that does this already?
Initially I was just looking at output for LISTSTATUS. I discovered that WebHDFS responds with sorted keys, but HttpFS doesn't. Then I found other responses from HttpFS also aren't sorted but WebHDFS does. So I extended the scope of this jira.
There was a problem hiding this comment.
I honestly don't think people care about the order.
There was a problem hiding this comment.
You are right. People won't care in production.
I filed this jira just because I was comparing the RAW JSON, and they weren't in the same order.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.