Skip to content

HDDS-1820. Fix numKeys metrics in OM HA. #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2019
Merged

HDDS-1820. Fix numKeys metrics in OM HA. #1116

merged 1 commit into from
Jul 18, 2019

Conversation

bharatviswa504
Copy link
Contributor

No description provided.

@bharatviswa504 bharatviswa504 requested a review from arp7 July 17, 2019 22:58
@bharatviswa504 bharatviswa504 self-assigned this Jul 17, 2019
arp7
arp7 approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@arp7 arp7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 71 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 505 trunk passed
+1 compile 263 trunk passed
+1 checkstyle 72 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 966 branch has no errors when building and testing our client artifacts.
+1 javadoc 179 trunk passed
0 spotbugs 355 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 587 trunk passed
_ Patch Compile Tests _
+1 mvninstall 456 the patch passed
+1 compile 289 the patch passed
+1 javac 289 the patch passed
+1 checkstyle 87 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 750 patch has no errors when building and testing our client artifacts.
+1 javadoc 182 the patch passed
+1 findbugs 619 the patch passed
_ Other Tests _
-1 unit 342 hadoop-hdds in the patch failed.
-1 unit 1932 hadoop-ozone in the patch failed.
+1 asflicense 59 The patch does not generate ASF License warnings.
7529
Reason Tests
Failed junit tests hadoop.hdds.scm.container.placement.algorithms.TestContainerPlacementFactory
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory
hadoop.ozone.container.server.TestSecureContainerServer
hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
hadoop.ozone.client.rpc.TestOzoneRpcClient
hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException
hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient
Subsystem Report/Notes
Docker Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1116/1/artifact/out/Dockerfile
GITHUB PR #1116
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 7f108350d731 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 5e6cc6f
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1116/1/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1116/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1116/1/testReport/
Max. process+thread count 5286 (vs. ulimit of 5500)
modules C: hadoop-ozone/ozone-manager U: hadoop-ozone/ozone-manager
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1116/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@bharatviswa504
Copy link
Contributor Author

Thank You @arp7 for the review.
Test failure is not related to this patch.
I will commit this to the trunk.

@bharatviswa504 bharatviswa504 merged commit f22818d into apache:trunk Jul 18, 2019
shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
@atoomula
Fixing SamzaSQL Latency Metrics resolution (apache#1116)
ec536e1
shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
@cameronlee314
Revert "Fixing SamzaSQL Latency Metrics resolution (apache#1116)" (ap…
97942d9 
…ache#1118)

This reverts commit ec536e1.

PR 1116 included some issues, which will be fixed in PR 1117: 1) semantic change to return values of IncomingMessageEnvelope.getEventTime and IncomingMessageEnvelope.getArrivalTime (changed from millis to nanos) which are public API methods, and it will be hard to find existing usages to make sure they are updated properly, 2) usages of constructor of IncomingMessageEnvelope was not updated to handle nanos correctly in certain places (e.g. KafkaConsumerProxy)
amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019
@bharatviswa504
HDDS-1820. Fix numKeys metrics in OM HA. (apache#1116)
852d63b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arp7 arp7 arp7 approved these changes

Assignees

@bharatviswa504 bharatviswa504

Labels
ozone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bharatviswa504 @hadoop-yetus @arp7