HDDS-1741 Fix prometheus configuration in ozoneperf example cluster #1045

fapifta · 2019-07-01T23:06:31Z

No description provided.

hadoop-yetus · 2019-07-02T01:00:59Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	125	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
0	yamllint	0	yamllint was not available.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1	mvninstall	527	trunk passed
+1	compile	272	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	1699	branch has no errors when building and testing our client artifacts.
+1	javadoc	172	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	455	the patch passed
+1	compile	280	the patch passed
+1	javac	280	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	735	patch has no errors when building and testing our client artifacts.
+1	javadoc	168	the patch passed
		_ Other Tests _
+1	unit	311	hadoop-hdds in the patch passed.
-1	unit	1825	hadoop-ozone in the patch failed.
+1	asflicense	44	The patch does not generate ASF License warnings.
		6015

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.container.common.statemachine.commandhandler.TestBlockDeletion
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestBCSID
	hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerByPipeline
	hadoop.ozone.client.rpc.TestWatchForCommit
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

Subsystem	Report/Notes
Docker	Client=18.09.5 Server=18.09.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1045/1/artifact/out/Dockerfile
GITHUB PR	#1045
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient yamllint
uname	Linux 883ff013bf73 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / d8bac50
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1045/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1045/1/testReport/
Max. process+thread count	5314 (vs. ulimit of 5500)
modules	C: hadoop-ozone/dist U: hadoop-ozone/dist
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1045/1/console
versions	git=2.7.4 maven=3.3.9
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

elek · 2019-07-02T02:12:57Z

/label ozone

hadoop-yetus · 2019-07-02T20:31:12Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	73	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
0	yamllint	1	yamllint was not available.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1	mvninstall	609	trunk passed
+1	compile	252	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	1668	branch has no errors when building and testing our client artifacts.
+1	javadoc	154	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	447	the patch passed
+1	compile	268	the patch passed
+1	javac	268	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	683	patch has no errors when building and testing our client artifacts.
+1	javadoc	152	the patch passed
		_ Other Tests _
-1	unit	285	hadoop-hdds in the patch failed.
-1	unit	2032	hadoop-ozone in the patch failed.
+1	asflicense	46	The patch does not generate ASF License warnings.
		6001

Reason	Tests
Failed junit tests	hadoop.hdds.scm.container.placement.algorithms.TestSCMContainerPlacementRackAware
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestFailureHandlingByClient
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.client.rpc.TestCommitWatcher

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1045/2/artifact/out/Dockerfile
GITHUB PR	#1045
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient yamllint
uname	Linux c59f15ace3e1 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `564758a`
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1045/2/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1045/2/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1045/2/testReport/
Max. process+thread count	5057 (vs. ulimit of 5500)
modules	C: hadoop-ozone/dist U: hadoop-ozone/dist
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1045/2/console
versions	git=2.7.4 maven=3.3.9
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-07-03T06:37:46Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	97	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
0	yamllint	0	yamllint was not available.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1	mvninstall	552	trunk passed
+1	compile	265	trunk passed
+1	mvnsite	0	trunk passed
-1	shadedclient	1672	branch has errors when building and testing our client artifacts.
+1	javadoc	167	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	507	the patch passed
+1	compile	267	the patch passed
+1	javac	267	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	712	patch has no errors when building and testing our client artifacts.
+1	javadoc	145	the patch passed
		_ Other Tests _
-1	unit	360	hadoop-hdds in the patch failed.
-1	unit	2343	hadoop-ozone in the patch failed.
+1	asflicense	45	The patch does not generate ASF License warnings.
		6501

Reason	Tests
Failed junit tests	hadoop.hdds.scm.block.TestBlockManager
	hadoop.ozone.container.common.statemachine.commandhandler.TestBlockDeletion
	hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.TestMiniOzoneCluster
	hadoop.ozone.container.server.TestSecureContainerServer

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1045/3/artifact/out/Dockerfile
GITHUB PR	#1045
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient yamllint
uname	Linux 43c4a38a77ea 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 15d82fc
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1045/3/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1045/3/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1045/3/testReport/
Max. process+thread count	5058 (vs. ulimit of 5500)
modules	C: hadoop-ozone/dist U: hadoop-ozone/dist
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1045/3/console
versions	git=2.7.4 maven=3.3.9
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

elek

+1 LGTM

Thanks to fix it @fapifta

I tested it with compose/ozoneperf and worked well (target was up under http://localhost:9090/targets)

Closes apache#1045

Closes #1045

…ger when using StorageConfig (apache#1045)

Closes apache#1045

HDDS-1741 Fix prometheus configuration in ozoneperf example cluster

73bb5d5

elek added the ozone label Jul 2, 2019

Merge remote-tracking branch 'upstream/trunk' into trunk

e0061cf

Merge remote-tracking branch 'upstream/trunk' into trunk

5455ae7

elek approved these changes Jul 3, 2019

View reviewed changes

elek closed this in acd2d52 Jul 3, 2019

bshashikant pushed a commit to bshashikant/hadoop that referenced this pull request Jul 10, 2019

HDDS-1741. Fix prometheus configuration in ozoneperf example cluster

252f498

Closes apache#1045

elek pushed a commit that referenced this pull request Jul 10, 2019

HDDS-1741. Fix prometheus configuration in ozoneperf example cluster

661e30a

Closes #1045

shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019

SAMZA-2209: Explicitly handle empty Optionals in ContainerStorageMana…

f847b8d

…ger when using StorageConfig (apache#1045)

amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019

HDDS-1741. Fix prometheus configuration in ozoneperf example cluster

e034e99

Closes apache#1045

K0K0V0K mentioned this pull request Nov 9, 2022

HADOOP-15327. Upgrade MR ShuffleHandler to use Netty4 #3259

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HDDS-1741 Fix prometheus configuration in ozoneperf example cluster #1045

HDDS-1741 Fix prometheus configuration in ozoneperf example cluster #1045

Uh oh!

fapifta commented Jul 1, 2019

Uh oh!

hadoop-yetus commented Jul 2, 2019

Uh oh!

elek commented Jul 2, 2019

Uh oh!

hadoop-yetus commented Jul 2, 2019

Uh oh!

hadoop-yetus commented Jul 3, 2019

Uh oh!

elek left a comment

Uh oh!

Uh oh!

HDDS-1741 Fix prometheus configuration in ozoneperf example cluster #1045

HDDS-1741 Fix prometheus configuration in ozoneperf example cluster #1045

Uh oh!

Conversation

fapifta commented Jul 1, 2019

Uh oh!

hadoop-yetus commented Jul 2, 2019

Uh oh!

elek commented Jul 2, 2019

Uh oh!

hadoop-yetus commented Jul 2, 2019

Uh oh!

hadoop-yetus commented Jul 3, 2019

Uh oh!

elek left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!