You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this Jira, we shall use generate Resourcename from actual resource names like volume/bucket/user/key inside OzoneManagerLock. In this way, users using these locking API's no need to worry of calling these additional API of generateResourceName in OzoneManagerLockUtil. And this also reduces code during acquiring locks in OM operations.
The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1
mvninstall
505
trunk passed
+1
compile
247
trunk passed
+1
checkstyle
72
trunk passed
+1
mvnsite
0
trunk passed
+1
shadedclient
904
branch has no errors when building and testing our client artifacts.
+1
javadoc
154
trunk passed
0
spotbugs
324
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
514
trunk passed
_ Patch Compile Tests _
+1
mvninstall
479
the patch passed
+1
compile
284
the patch passed
+1
javac
284
the patch passed
+1
checkstyle
86
the patch passed
+1
mvnsite
0
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
812
patch has no errors when building and testing our client artifacts.
+1
javadoc
166
the patch passed
-1
findbugs
328
hadoop-ozone generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1
unit
322
hadoop-hdds in the patch passed.
-1
unit
54
hadoop-ozone in the patch failed.
+1
asflicense
39
The patch does not generate ASF License warnings.
5459
Reason
Tests
FindBugs
module:hadoop-ozone
Comparison of String objects using == or != in org.apache.hadoop.ozone.om.lock.OzoneManagerLock.generateResourceName(OzoneManagerLock$Resource, String[]) At OzoneManagerLock.java:== or != in org.apache.hadoop.ozone.om.lock.OzoneManagerLock.generateResourceName(OzoneManagerLock$Resource, String[]) At OzoneManagerLock.java:[line 128]
The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1
mvninstall
474
trunk passed
+1
compile
259
trunk passed
+1
checkstyle
67
trunk passed
+1
mvnsite
0
trunk passed
+1
shadedclient
837
branch has no errors when building and testing our client artifacts.
+1
javadoc
143
trunk passed
0
spotbugs
316
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
506
trunk passed
_ Patch Compile Tests _
+1
mvninstall
436
the patch passed
+1
compile
245
the patch passed
+1
javac
245
the patch passed
+1
checkstyle
68
the patch passed
+1
mvnsite
0
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
615
patch has no errors when building and testing our client artifacts.
+1
javadoc
144
the patch passed
-1
findbugs
311
hadoop-ozone generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
-1
unit
233
hadoop-hdds in the patch failed.
-1
unit
992
hadoop-ozone in the patch failed.
+1
asflicense
44
The patch does not generate ASF License warnings.
5751
Reason
Tests
FindBugs
module:hadoop-ozone
Comparison of String objects using == or != in org.apache.hadoop.ozone.om.lock.OzoneManagerLock.generateResourceName(OzoneManagerLock$Resource, String[]) At OzoneManagerLock.java:== or != in org.apache.hadoop.ozone.om.lock.OzoneManagerLock.generateResourceName(OzoneManagerLock$Resource, String[]) At OzoneManagerLock.java:[line 128]
The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1
mvninstall
531
trunk passed
+1
compile
259
trunk passed
+1
checkstyle
65
trunk passed
+1
mvnsite
0
trunk passed
+1
shadedclient
851
branch has no errors when building and testing our client artifacts.
+1
javadoc
159
trunk passed
0
spotbugs
337
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
544
trunk passed
_ Patch Compile Tests _
+1
mvninstall
469
the patch passed
+1
compile
271
the patch passed
+1
javac
271
the patch passed
+1
checkstyle
71
the patch passed
+1
mvnsite
0
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
659
patch has no errors when building and testing our client artifacts.
+1
javadoc
138
the patch passed
-1
findbugs
321
hadoop-ozone generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
-1
unit
160
hadoop-hdds in the patch failed.
-1
unit
1393
hadoop-ozone in the patch failed.
+1
asflicense
40
The patch does not generate ASF License warnings.
6312
Reason
Tests
FindBugs
module:hadoop-ozone
Comparison of String objects using == or != in org.apache.hadoop.ozone.om.lock.OzoneManagerLock.generateResourceName(OzoneManagerLock$Resource, String[]) At OzoneManagerLock.java:== or != in org.apache.hadoop.ozone.om.lock.OzoneManagerLock.generateResourceName(OzoneManagerLock$Resource, String[]) At OzoneManagerLock.java:[line 128]
The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1
mvninstall
561
trunk passed
+1
compile
310
trunk passed
+1
checkstyle
87
trunk passed
+1
mvnsite
0
trunk passed
+1
shadedclient
944
branch has no errors when building and testing our client artifacts.
+1
javadoc
157
trunk passed
0
spotbugs
329
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
530
trunk passed
_ Patch Compile Tests _
+1
mvninstall
491
the patch passed
+1
compile
294
the patch passed
+1
javac
294
the patch passed
+1
checkstyle
85
the patch passed
+1
mvnsite
0
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
825
patch has no errors when building and testing our client artifacts.
+1
javadoc
177
the patch passed
-1
findbugs
362
hadoop-ozone generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1
unit
309
hadoop-hdds in the patch passed.
-1
unit
1681
hadoop-ozone in the patch failed.
+1
asflicense
47
The patch does not generate ASF License warnings.
7333
Reason
Tests
FindBugs
module:hadoop-ozone
Comparison of String objects using == or != in org.apache.hadoop.ozone.om.lock.OzoneManagerLock.generateResourceName(OzoneManagerLock$Resource, String[]) At OzoneManagerLock.java:== or != in org.apache.hadoop.ozone.om.lock.OzoneManagerLock.generateResourceName(OzoneManagerLock$Resource, String[]) At OzoneManagerLock.java:[line 128]
The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
0
mvndep
27
Maven dependency ordering for branch
+1
mvninstall
484
trunk passed
+1
compile
256
trunk passed
+1
checkstyle
62
trunk passed
+1
mvnsite
0
trunk passed
+1
shadedclient
815
branch has no errors when building and testing our client artifacts.
+1
javadoc
164
trunk passed
0
spotbugs
319
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
507
trunk passed
_ Patch Compile Tests _
0
mvndep
32
Maven dependency ordering for patch
+1
mvninstall
441
the patch passed
+1
compile
260
the patch passed
+1
javac
260
the patch passed
+1
checkstyle
78
the patch passed
+1
mvnsite
0
the patch passed
+1
whitespace
1
The patch has no whitespace issues.
+1
shadedclient
644
patch has no errors when building and testing our client artifacts.
+1
javadoc
141
the patch passed
-1
findbugs
305
hadoop-ozone generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1
unit
248
hadoop-hdds in the patch passed.
-1
unit
1374
hadoop-ozone in the patch failed.
+1
asflicense
49
The patch does not generate ASF License warnings.
6284
Reason
Tests
FindBugs
module:hadoop-ozone
Comparison of String objects using == or != in org.apache.hadoop.ozone.om.lock.OzoneManagerLock.generateResourceName(OzoneManagerLock$Resource, String[]) At OzoneManagerLock.java:== or != in org.apache.hadoop.ozone.om.lock.OzoneManagerLock.generateResourceName(OzoneManagerLock$Resource, String[]) At OzoneManagerLock.java:[line 128]
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this Jira, we shall use generate Resourcename from actual resource names like volume/bucket/user/key inside OzoneManagerLock. In this way, users using these locking API's no need to worry of calling these additional API of generateResourceName in OzoneManagerLockUtil. And this also reduces code during acquiring locks in OM operations.