Skip to content

HDDS-1727. Use generation of resourceName for locks in OzoneManagerLock. #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2019

Conversation

bharatviswa504
Copy link
Contributor

@bharatviswa504 bharatviswa504 commented Jun 25, 2019

In this Jira, we shall use generate Resourcename from actual resource names like volume/bucket/user/key inside OzoneManagerLock. In this way, users using these locking API's no need to worry of calling these additional API of generateResourceName in OzoneManagerLockUtil. And this also reduces code during acquiring locks in OM operations.

Copy link
Contributor

@anuengineer anuengineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, This is a beautiful change. Thanks for doing this. Please commit at will.

@bharatviswa504 bharatviswa504 force-pushed the HDDS-1727 branch 5 times, most recently from f3328fc to b1471f6 Compare June 25, 2019 20:27
@bharatviswa504
Copy link
Contributor Author

/retest

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 105 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 mvninstall 505 trunk passed
+1 compile 247 trunk passed
+1 checkstyle 72 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 904 branch has no errors when building and testing our client artifacts.
+1 javadoc 154 trunk passed
0 spotbugs 324 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 514 trunk passed
_ Patch Compile Tests _
+1 mvninstall 479 the patch passed
+1 compile 284 the patch passed
+1 javac 284 the patch passed
+1 checkstyle 86 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 812 patch has no errors when building and testing our client artifacts.
+1 javadoc 166 the patch passed
-1 findbugs 328 hadoop-ozone generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1 unit 322 hadoop-hdds in the patch passed.
-1 unit 54 hadoop-ozone in the patch failed.
+1 asflicense 39 The patch does not generate ASF License warnings.
5459
Reason Tests
FindBugs module:hadoop-ozone
Comparison of String objects using == or != in org.apache.hadoop.ozone.om.lock.OzoneManagerLock.generateResourceName(OzoneManagerLock$Resource, String[]) At OzoneManagerLock.java:== or != in org.apache.hadoop.ozone.om.lock.OzoneManagerLock.generateResourceName(OzoneManagerLock$Resource, String[]) At OzoneManagerLock.java:[line 128]
Failed junit tests hadoop.ozone.om.lock.TestOzoneManagerLock
Subsystem Report/Notes
Docker Client=18.09.5 Server=18.09.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1014/1/artifact/out/Dockerfile
GITHUB PR #1014
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 0af0512a3ba7 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 049bb42
Default Java 1.8.0_212
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1014/1/artifact/out/new-findbugs-hadoop-ozone.html
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1014/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1014/1/testReport/
Max. process+thread count 434 (vs. ulimit of 5500)
modules C: hadoop-ozone/common U: hadoop-ozone/common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1014/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 31 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 mvninstall 474 trunk passed
+1 compile 259 trunk passed
+1 checkstyle 67 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 837 branch has no errors when building and testing our client artifacts.
+1 javadoc 143 trunk passed
0 spotbugs 316 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 506 trunk passed
_ Patch Compile Tests _
+1 mvninstall 436 the patch passed
+1 compile 245 the patch passed
+1 javac 245 the patch passed
+1 checkstyle 68 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 615 patch has no errors when building and testing our client artifacts.
+1 javadoc 144 the patch passed
-1 findbugs 311 hadoop-ozone generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
-1 unit 233 hadoop-hdds in the patch failed.
-1 unit 992 hadoop-ozone in the patch failed.
+1 asflicense 44 The patch does not generate ASF License warnings.
5751
Reason Tests
FindBugs module:hadoop-ozone
Comparison of String objects using == or != in org.apache.hadoop.ozone.om.lock.OzoneManagerLock.generateResourceName(OzoneManagerLock$Resource, String[]) At OzoneManagerLock.java:== or != in org.apache.hadoop.ozone.om.lock.OzoneManagerLock.generateResourceName(OzoneManagerLock$Resource, String[]) At OzoneManagerLock.java:[line 128]
Failed junit tests hadoop.hdds.scm.container.placement.algorithms.TestSCMContainerPlacementRackAware
hadoop.ozone.client.rpc.TestOzoneRpcClient
hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1014/2/artifact/out/Dockerfile
GITHUB PR #1014
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 6c144a18c457 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 049bb42
Default Java 1.8.0_212
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1014/2/artifact/out/new-findbugs-hadoop-ozone.html
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1014/2/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1014/2/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1014/2/testReport/
Max. process+thread count 5135 (vs. ulimit of 5500)
modules C: hadoop-ozone/common U: hadoop-ozone/common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1014/2/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 32 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 mvninstall 531 trunk passed
+1 compile 259 trunk passed
+1 checkstyle 65 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 851 branch has no errors when building and testing our client artifacts.
+1 javadoc 159 trunk passed
0 spotbugs 337 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 544 trunk passed
_ Patch Compile Tests _
+1 mvninstall 469 the patch passed
+1 compile 271 the patch passed
+1 javac 271 the patch passed
+1 checkstyle 71 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 659 patch has no errors when building and testing our client artifacts.
+1 javadoc 138 the patch passed
-1 findbugs 321 hadoop-ozone generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
-1 unit 160 hadoop-hdds in the patch failed.
-1 unit 1393 hadoop-ozone in the patch failed.
+1 asflicense 40 The patch does not generate ASF License warnings.
6312
Reason Tests
FindBugs module:hadoop-ozone
Comparison of String objects using == or != in org.apache.hadoop.ozone.om.lock.OzoneManagerLock.generateResourceName(OzoneManagerLock$Resource, String[]) At OzoneManagerLock.java:== or != in org.apache.hadoop.ozone.om.lock.OzoneManagerLock.generateResourceName(OzoneManagerLock$Resource, String[]) At OzoneManagerLock.java:[line 128]
Failed junit tests hadoop.ozone.container.ozoneimpl.TestOzoneContainer
hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
hadoop.ozone.TestMiniChaosOzoneCluster
hadoop.hdds.scm.pipeline.TestRatisPipelineProvider
hadoop.ozone.client.rpc.TestOzoneRpcClient
hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
hadoop.ozone.client.rpc.TestFailureHandlingByClient
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1014/4/artifact/out/Dockerfile
GITHUB PR #1014
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 2a350236f4b5 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 049bb42
Default Java 1.8.0_212
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1014/4/artifact/out/new-findbugs-hadoop-ozone.html
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1014/4/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1014/4/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1014/4/testReport/
Max. process+thread count 3944 (vs. ulimit of 5500)
modules C: hadoop-ozone/common U: hadoop-ozone/common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1014/4/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 81 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 mvninstall 561 trunk passed
+1 compile 310 trunk passed
+1 checkstyle 87 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 944 branch has no errors when building and testing our client artifacts.
+1 javadoc 157 trunk passed
0 spotbugs 329 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 530 trunk passed
_ Patch Compile Tests _
+1 mvninstall 491 the patch passed
+1 compile 294 the patch passed
+1 javac 294 the patch passed
+1 checkstyle 85 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 825 patch has no errors when building and testing our client artifacts.
+1 javadoc 177 the patch passed
-1 findbugs 362 hadoop-ozone generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1 unit 309 hadoop-hdds in the patch passed.
-1 unit 1681 hadoop-ozone in the patch failed.
+1 asflicense 47 The patch does not generate ASF License warnings.
7333
Reason Tests
FindBugs module:hadoop-ozone
Comparison of String objects using == or != in org.apache.hadoop.ozone.om.lock.OzoneManagerLock.generateResourceName(OzoneManagerLock$Resource, String[]) At OzoneManagerLock.java:== or != in org.apache.hadoop.ozone.om.lock.OzoneManagerLock.generateResourceName(OzoneManagerLock$Resource, String[]) At OzoneManagerLock.java:[line 128]
Failed junit tests hadoop.ozone.TestMiniChaosOzoneCluster
hadoop.ozone.client.rpc.TestReadRetries
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
hadoop.hdds.scm.pipeline.TestRatisPipelineProvider
Subsystem Report/Notes
Docker Client=18.09.5 Server=18.09.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1014/3/artifact/out/Dockerfile
GITHUB PR #1014
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 34d0627a15b2 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 049bb42
Default Java 1.8.0_212
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1014/3/artifact/out/new-findbugs-hadoop-ozone.html
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1014/3/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1014/3/testReport/
Max. process+thread count 4115 (vs. ulimit of 5500)
modules C: hadoop-ozone/common U: hadoop-ozone/common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1014/3/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 31 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
0 mvndep 27 Maven dependency ordering for branch
+1 mvninstall 484 trunk passed
+1 compile 256 trunk passed
+1 checkstyle 62 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 815 branch has no errors when building and testing our client artifacts.
+1 javadoc 164 trunk passed
0 spotbugs 319 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 507 trunk passed
_ Patch Compile Tests _
0 mvndep 32 Maven dependency ordering for patch
+1 mvninstall 441 the patch passed
+1 compile 260 the patch passed
+1 javac 260 the patch passed
+1 checkstyle 78 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 1 The patch has no whitespace issues.
+1 shadedclient 644 patch has no errors when building and testing our client artifacts.
+1 javadoc 141 the patch passed
-1 findbugs 305 hadoop-ozone generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1 unit 248 hadoop-hdds in the patch passed.
-1 unit 1374 hadoop-ozone in the patch failed.
+1 asflicense 49 The patch does not generate ASF License warnings.
6284
Reason Tests
FindBugs module:hadoop-ozone
Comparison of String objects using == or != in org.apache.hadoop.ozone.om.lock.OzoneManagerLock.generateResourceName(OzoneManagerLock$Resource, String[]) At OzoneManagerLock.java:== or != in org.apache.hadoop.ozone.om.lock.OzoneManagerLock.generateResourceName(OzoneManagerLock$Resource, String[]) At OzoneManagerLock.java:[line 128]
Failed junit tests hadoop.hdds.scm.pipeline.TestRatisPipelineProvider
hadoop.ozone.client.rpc.TestFailureHandlingByClient
hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
hadoop.ozone.client.rpc.TestOzoneRpcClient
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1014/7/artifact/out/Dockerfile
GITHUB PR #1014
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux edf2101e22ce 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 049bb42
Default Java 1.8.0_212
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-1014/7/artifact/out/new-findbugs-hadoop-ozone.html
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1014/7/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1014/7/testReport/
Max. process+thread count 4555 (vs. ulimit of 5500)
modules C: hadoop-hdds/common hadoop-ozone/common U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1014/7/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@bharatviswa504 bharatviswa504 self-assigned this Jun 25, 2019
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 30 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
0 mvndep 24 Maven dependency ordering for branch
+1 mvninstall 483 trunk passed
+1 compile 249 trunk passed
+1 checkstyle 60 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 813 branch has no errors when building and testing our client artifacts.
+1 javadoc 161 trunk passed
0 spotbugs 310 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 501 trunk passed
_ Patch Compile Tests _
0 mvndep 38 Maven dependency ordering for patch
+1 mvninstall 440 the patch passed
+1 compile 271 the patch passed
+1 javac 271 the patch passed
+1 checkstyle 71 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 635 patch has no errors when building and testing our client artifacts.
+1 javadoc 151 the patch passed
+1 findbugs 522 the patch passed
_ Other Tests _
+1 unit 234 hadoop-hdds in the patch passed.
-1 unit 1117 hadoop-ozone in the patch failed.
+1 asflicense 40 The patch does not generate ASF License warnings.
6015
Reason Tests
Failed junit tests hadoop.ozone.client.rpc.TestOzoneRpcClient
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
hadoop.ozone.web.client.TestOzoneClient
hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1014/8/artifact/out/Dockerfile
GITHUB PR #1014
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux c87545381e50 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 4b50981
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1014/8/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1014/8/testReport/
Max. process+thread count 4618 (vs. ulimit of 5500)
modules C: hadoop-hdds/common hadoop-ozone/common U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1014/8/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@bharatviswa504
Copy link
Contributor Author

Test failures are not related to this patch.
Thank You @anuengineer for the review. I will commit this to the trunk.

@bharatviswa504 bharatviswa504 merged commit a79bdf7 into apache:trunk Jun 26, 2019
bshashikant pushed a commit to bshashikant/hadoop that referenced this pull request Jul 10, 2019
shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
Author: Ray Matharu <rmatharu@linkedin.com>

Reviewers: Prateek Maheshwari <pmaheshwari@apache.org>

Closes apache#1014 from rmatharu/gradle-upgrade-4.8
amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants