Skip to content

HDDS-1716. Smoketest results are generated with an internal user #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

elek
Copy link
Member

@elek elek commented Jun 21, 2019

[~eyang] reported the problem in HDDS-1609 that the smoketest results are generated a user (the user inside the docker container) which can be different from the host user.

There is a minimal risk that the test results can be deleted/corrupted by an other users if the current user is different from uid=1000

I opened this issue because [~eyang] said me during an offline discussion that HDDS-1609 is a more complex issue and not only about the ownership of the test results.

I suggest to handle the two problems in different way. With this patch, the permission of the test result files can be fixed easily.

In HDDS-1609 we can discuss about general security problems and try to find generic solution for them.

Steps to reproduce this the problem:

  • Use a user which is different from uid=1000
  • Create a new ozone build (mvn clean install -f pom.ozone.xml -DskipTests)
  • Go to a compose directory (cd hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/compose/)
  • Execute tests (./test.sh)
  • check the ownership of the results (ls -lah ./results)

Current result: the owner of the result files are the user uid=1000

Expected result: the owner of the files should be always the current user (even if the current uid is different)

 

See: https://issues.apache.org/jira/browse/HDDS-1716

@elek elek added the ozone label Jun 21, 2019
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 72 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
0 shelldocs 0 Shelldocs was not available.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 494 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 959 branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 mvninstall 535 the patch passed
+1 mvnsite 0 the patch passed
-1 shellcheck 0 The patch generated 6 new + 1 unchanged - 0 fixed = 7 total (was 1)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 813 patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 unit 114 hadoop-hdds in the patch passed.
+1 unit 191 hadoop-ozone in the patch passed.
+1 asflicense 48 The patch does not generate ASF License warnings.
3435
Subsystem Report/Notes
Docker Client=18.09.5 Server=18.09.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1002/1/artifact/out/Dockerfile
GITHUB PR #1002
Optional Tests dupname asflicense mvnsite unit shellcheck shelldocs
uname Linux 66b9ae8a8755 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 83dcb9d
shellcheck https://builds.apache.org/job/hadoop-multibranch/job/PR-1002/1/artifact/out/diff-patch-shellcheck.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1002/1/testReport/
Max. process+thread count 306 (vs. ulimit of 5500)
modules C: hadoop-ozone/dist U: hadoop-ozone/dist
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1002/1/console
versions git=2.7.4 maven=3.3.9 shellcheck=0.4.6
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 70 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
0 shelldocs 1 Shelldocs was not available.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 474 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 839 branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 mvninstall 437 the patch passed
+1 mvnsite 0 the patch passed
+1 shellcheck 2 There were no new shellcheck issues.
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 745 patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 unit 111 hadoop-hdds in the patch passed.
+1 unit 187 hadoop-ozone in the patch passed.
+1 asflicense 49 The patch does not generate ASF License warnings.
3112
Subsystem Report/Notes
Docker Client=18.09.5 Server=18.09.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1002/2/artifact/out/Dockerfile
GITHUB PR #1002
Optional Tests dupname asflicense mvnsite unit shellcheck shelldocs
uname Linux 3dbb9f3b1d3f 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / d203045
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1002/2/testReport/
Max. process+thread count 307 (vs. ulimit of 5500)
modules C: hadoop-ozone/dist U: hadoop-ozone/dist
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1002/2/console
versions git=2.7.4 maven=3.3.9 shellcheck=0.4.6
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 74 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
0 shelldocs 1 Shelldocs was not available.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 514 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 831 branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 mvninstall 434 the patch passed
+1 mvnsite 0 the patch passed
+1 shellcheck 2 There were no new shellcheck issues.
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 730 patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 unit 99 hadoop-hdds in the patch passed.
+1 unit 170 hadoop-ozone in the patch passed.
+1 asflicense 43 The patch does not generate ASF License warnings.
3084
Subsystem Report/Notes
Docker Client=18.09.5 Server=18.09.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1002/3/artifact/out/Dockerfile
GITHUB PR #1002
Optional Tests dupname asflicense mvnsite unit shellcheck shelldocs
uname Linux 9837b950f400 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 564758a
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1002/3/testReport/
Max. process+thread count 306 (vs. ulimit of 5500)
modules C: hadoop-ozone/dist U: hadoop-ozone/dist
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1002/3/console
versions git=2.7.4 maven=3.3.9 shellcheck=0.4.6
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@elek elek closed this in 75b1e45 Jul 2, 2019
bshashikant pushed a commit to bshashikant/hadoop that referenced this pull request Jul 10, 2019
shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants