HADOOP-16202 style and javadoc warnings

Change-Id: I1e454d3244ffab8c248584edfb1f539ebac596c7

Author: steveloughran

hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FutureDataInputStreamBuilder.java

@@ -28,12 +28,12 @@
  * Builder for input streams and subclasses whose return value is
  * actually a completable future: this allows for better asynchronous
  * operation.
- * <p></p>
+ *
  * To be more generic, {@link #opt(String, int)} and {@link #must(String, int)}
  * variants provide implementation-agnostic way to customize the builder.
  * Each FS-specific builder implementation can interpret the FS-specific
  * options accordingly, for example:
- * <p></p>
+ *
  * If the option is not related to the file system, the option will be ignored.
  * If the option is must, but not supported/known by the file system, an
  * {@link IllegalArgumentException} will be thrown.

hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/AbstractFSBuilderImpl.java

@@ -42,20 +42,18 @@
 /**
  * Builder for filesystem/filecontext operations of various kinds,
  * with option support.
- * <p></p>
- * <pre>
+ *
+ * <code>
  *   .opt("foofs:option.a", true)
  *   .opt("foofs:option.b", "value")
  *   .opt("fs.s3a.open.option.etag", "9fe4c37c25b")
  *   .must("foofs:cache", true)
  *   .must("barfs:cache-size", 256 * 1024 * 1024)
  *   .build();
- * </pre>
- * <p></p>
+ * </code>
  *
  * Configuration keys declared in an {@code opt()} may be ignored by
  * a builder which does not recognise them.
- * <p></p>
  *
  * Configuration keys declared in a {@code must()} function set must
  * be understood by the implementation or a

hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/FutureDataInputStreamBuilderImpl.java

@@ -41,15 +41,16 @@
  * Builder for input streams and subclasses whose return value is
  * actually a completable future: this allows for better asynchronous
  * operation.
- * <p></p>
+ *
  * To be more generic, {@link #opt(String, int)} and {@link #must(String, int)}
  * variants provide implementation-agnostic way to customize the builder.
  * Each FS-specific builder implementation can interpret the FS-specific
  * options accordingly, for example:
- * <p></p>
+ *
  * If the option is not related to the file system, the option will be ignored.
  * If the option is must, but not supported/known by the file system, an
  * {@link IllegalArgumentException} will be thrown.
+ *
  */
 @InterfaceAudience.Public
 @InterfaceStability.Unstable

hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractOpenTest.java

@@ -343,7 +343,8 @@ public void testOpenFileApplyAsyncRead() throws Throwable {
   @Test
   public void testOpenFileNullStatusButFileLength() throws Throwable {
     describe("use openFile() with a null status and expect the status to be"
-        + " ignored. block size, fadvise and length are passed in as must() options");
+        + " ignored. block size, fadvise and length are passed in as"
+        + " must() options");
     Path path = path("testOpenFileNullStatus");
     FileSystem fs = getFileSystem();
     int len = 4;

hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryCopyService.java

@@ -37,7 +37,6 @@
 
 import static org.apache.hadoop.fs.Options.OpenFileOptions.FS_OPTION_OPENFILE_FADVISE;
 import static org.apache.hadoop.fs.Options.OpenFileOptions.FS_OPTION_OPENFILE_FADVISE_SEQUENTIAL;
-import static org.apache.hadoop.fs.Options.OpenFileOptions.FS_OPTION_OPENFILE_LENGTH;
 import static org.apache.hadoop.fs.impl.FutureIOSupport.awaitFuture;
 
 /**

hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/S3AOpenFileOperation.java

@@ -312,7 +312,8 @@ public OpenFileInformation prepareToOpenFile(
 
   /**
    * Open a simple file.
-   * @return the parameters needed to open a file through open(path, bufferSize).
+   * @return the parameters needed to open a file through
+   * {@code open(path, bufferSize)}.
    * @param bufferSize  buffer size
    */
   public OpenFileInformation openSimpleFile(final int bufferSize,

hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/contract/s3a/ITestS3AContractSeek.java

@@ -24,7 +24,6 @@
 import java.util.Arrays;
 import java.util.Collection;
 
-import org.assertj.core.api.Assertions;
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -45,7 +44,6 @@
 import org.apache.hadoop.security.ssl.DelegatingSSLSocketFactory;
 import org.apache.hadoop.util.NativeCodeLoader;
 
-import static org.apache.hadoop.fs.Options.OpenFileOptions.FS_OPTION_OPENFILE_FADVISE;
 import static org.apache.hadoop.thirdparty.com.google.common.base.Preconditions.checkNotNull;
 import static org.apache.hadoop.fs.s3a.Constants.INPUT_FADVISE;
 import static org.apache.hadoop.fs.s3a.Constants.INPUT_FADV_NORMAL;

hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/performance/ITestS3AOpenCost.java

@@ -194,12 +194,12 @@ public void testOpenFileLongerLength() throws Throwable {
       byte[] out = new byte[(int) longLen];
       intercept(EOFException.class,
           () -> in3.readFully(0, out));
-        in3.seek(longLen - 1);
-        assertEquals("read past real EOF on " + in3,
-            -1, in3.read());
-        in3.close();
-        return in3.toString();
-      },
+      in3.seek(longLen - 1);
+      assertEquals("read past real EOF on " + in3,
+          -1, in3.read());
+      in3.close();
+      return in3.toString();
+    },
         // two GET calls were made, one for readFully,
         // the second on the read() past the EOF
         // the operation has got as far as S3