YARN-11536. Fix CheckStyle.

Author: slfan1989

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/FederationQueueWeight.java

@@ -75,6 +75,19 @@ public static FederationQueueWeight newInstance(String routerWeight,
     return federationQueueWeight;
   }
 
+  @Private
+  @Unstable
+  public static FederationQueueWeight newInstance(String routerWeight,
+      String amrmWeight, String headRoomAlpha, String queue, String policyManagerClassName) {
+    FederationQueueWeight federationQueueWeight = Records.newRecord(FederationQueueWeight.class);
+    federationQueueWeight.setRouterWeight(routerWeight);
+    federationQueueWeight.setAmrmWeight(amrmWeight);
+    federationQueueWeight.setHeadRoomAlpha(headRoomAlpha);
+    federationQueueWeight.setQueue(queue);
+    federationQueueWeight.setPolicyManagerClassName(policyManagerClassName);
+    return federationQueueWeight;
+  }
+
   @Public
   @Unstable
   public abstract String getRouterWeight();
@@ -166,4 +179,20 @@ public static void checkHeadRoomAlphaValid(String headRoomAlpha) throws YarnExce
   protected static boolean isNumeric(String value) {
     return NumberUtils.isCreatable(value);
   }
+
+  @Public
+  @Unstable
+  public abstract String getQueue();
+
+  @Public
+  @Unstable
+  public abstract void setQueue(String queue);
+
+  @Public
+  @Unstable
+  public abstract String getPolicyManagerClassName();
+
+  @Public
+  @Unstable
+  public abstract void setPolicyManagerClassName(String policyManagerClassName);
 }

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto

@@ -444,6 +444,8 @@ message FederationQueueWeightProto {
   optional string routerWeight = 1;
   optional string amrmWeight = 2;
   optional string headRoomAlpha = 3;
+  optional string queue = 4;
+  optional string policyManagerClassName = 5;
 }
 
 ////////////////////////////////////////////////////////////////////////

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RouterCLI.java

@@ -109,6 +109,8 @@ public class RouterCLI extends Configured implements Tool {
 
   private static final String OPTION_BATCH_SAVE = "batch-save";
 
+  private static final String OPTION_FORMAT = "format";
+
   private static final String CMD_POLICY = "-policy";
   private static final String FORMAT_XML = "xml";
   private static final String FORMAT_JSON = "json";
@@ -312,7 +314,20 @@ private int handlePolicy(String[] args)
         "We will save the policy information of the queue, " +
         "including queue and weight information");
     saveOpt.setOptionalArg(true);
+    Option batchSaveOpt = new Option(OPTION_BATCH_S, OPTION_BATCH_SAVE, false,
+        "We will save queue policies in bulk, " +
+         "where users can provide XML or JSON files containing the policies. " +
+         "This command will parse the file contents and store the results " +
+         "in the FederationStateStore.");
+    Option formatOpt = new Option(null, "format", true,
+        "Users can specify the file format using this option. " +
+        "Currently, there are two supported file formats: XML and JSON. " +
+        "These files contain the policy information for storing queue policies.");
+    formatOpt.setOptionalArg(true);
+
     opts.addOption(saveOpt);
+    opts.addOption(batchSaveOpt);
+    opts.addOption(formatOpt);
 
     // Parse command line arguments.
     CommandLine cliParser;
@@ -325,6 +340,7 @@ private int handlePolicy(String[] args)
     }
 
     // Try to parse the cmd save.
+    // Save a single queue policy
     if (cliParser.hasOption(OPTION_S) || cliParser.hasOption(OPTION_SAVE)) {
       String policy = cliParser.getOptionValue(OPTION_S);
       if (StringUtils.isBlank(policy)) {
@@ -333,6 +349,21 @@ private int handlePolicy(String[] args)
       return handleSavePolicy(policy);
     }
 
+    // Save Queue Policies in Batches
+    if (cliParser.hasOption(OPTION_BATCH_S) || cliParser.hasOption(OPTION_BATCH_SAVE)) {
+      if (cliParser.hasOption(OPTION_FORMAT)) {
+        String format = cliParser.getOptionValue(OPTION_FORMAT);
+        if (StringUtils.isBlank(format) ||
+           StringUtils.equalsAnyIgnoreCase(format, FORMAT_XML, FORMAT_JSON)) {
+          System.out.println("We currently only support policy configuration files " +
+              "in XML and JSON formats.");
+          return EXIT_ERROR;
+        }
+        System.out.println("format:" + format);
+      }
+      System.out.println("We need to specify the format of the input file.");
+    }
+
     return EXIT_ERROR;
   }
 

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/FederationQueueWeightPBImpl.java

@@ -114,6 +114,26 @@ public void setHeadRoomAlpha(String headRoomAlpha) {
     builder.setHeadRoomAlpha(headRoomAlpha);
   }
 
+  @Override
+  public String getQueue() {
+    return null;
+  }
+
+  @Override
+  public void setQueue(String queue) {
+
+  }
+
+  @Override
+  public String getPolicyManagerClassName() {
+    return null;
+  }
+
+  @Override
+  public void setPolicyManagerClassName(String policyManagerClassName) {
+
+  }
+
   @Override
   public int hashCode() {
     return getProto().hashCode();