Skip to content

Commit f6283a9

Browse files
committed
comment, condition small refactor
1 parent e15ce58 commit f6283a9

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/utils/TracingContext.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -153,16 +153,16 @@ public void setListener(Listener listener) {
153153
* X_MS_CLIENT_REQUEST_ID header of the http operation
154154
* @param httpOperation AbfsHttpOperation instance to set header into
155155
* connection
156-
* @param previousFailure Failure seen before this API trigger on
157-
* same operation from AbfsClient. It shall be non-null if it is a retry-iteration.
156+
* @param previousFailure Failure seen before this API trigger on same operation
157+
* from AbfsClient.
158158
*/
159159
public void constructHeader(AbfsHttpOperation httpOperation, String previousFailure) {
160160
clientRequestId = UUID.randomUUID().toString();
161161
switch (format) {
162162
case ALL_ID_FORMAT: // Optional IDs (e.g. streamId) may be empty
163163
header =
164164
clientCorrelationID + ":" + clientRequestId + ":" + fileSystemID + ":"
165-
+ getPrimaryRequestIdForHeader(previousFailure != null) + ":" + streamID
165+
+ getPrimaryRequestIdForHeader(retryCount > 0) + ":" + streamID
166166
+ ":" + opType + ":" + retryCount;
167167
header = addFailureReasons(header, previousFailure);
168168
break;
@@ -181,7 +181,7 @@ public void constructHeader(AbfsHttpOperation httpOperation, String previousFail
181181
* API call (previousFailure shall be null), maintain the last part of clientRequestId's
182182
* UUID in primaryRequestIdForRetry. This field shall be used as primaryRequestId part
183183
* of the x-ms-client-request-id header in case of retry of the same API-request.
184-
* */
184+
*/
185185
if (primaryRequestId.isEmpty() && previousFailure == null) {
186186
String[] clientRequestIdParts = clientRequestId.split("-");
187187
primaryRequestIdForRetry = clientRequestIdParts[
@@ -195,7 +195,7 @@ public void constructHeader(AbfsHttpOperation httpOperation, String previousFail
195195
* @return {@link #primaryRequestIdForRetry}:If the {@link #primaryRequestId}
196196
* is an empty-string, and it's a retry iteration.
197197
* {@link #primaryRequestId} for other cases.
198-
* */
198+
*/
199199
private String getPrimaryRequestIdForHeader(final Boolean isRetry) {
200200
if (!primaryRequestId.isEmpty() || !isRetry) {
201201
return primaryRequestId;

0 commit comments

Comments
 (0)