YARN-10885. Fix CheckStyle.

Author: slfan1989

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/utils/FederationStateStoreFacade.java

@@ -381,11 +381,11 @@ public SubClusterId getApplicationHomeSubCluster(ApplicationId appId)
     try {
       if (isCachingEnabled()) {
         Object value =
-            cache.get(buildGetApplicationHomeSubClusterRequest(appId.toString()));
-        if(value instanceof SubClusterId){
+            cache.get(buildGetApplicationHomeSubClusterRequest(appId));
+        if (value instanceof SubClusterId) {
           return (SubClusterId) value;
         } else {
-          throw new YarnException("Cannot be converted to a map.");
+          throw new YarnException("Cannot be converted to SubClusterId.");
         }
       } else {
         GetApplicationHomeSubClusterResponse response = stateStore.getApplicationHomeSubCluster(
@@ -528,15 +528,13 @@ public Map<String, SubClusterPolicyConfiguration> invoke(
     return cacheRequest;
   }
 
-  private Object buildGetApplicationHomeSubClusterRequest(String appId) {
+  private Object buildGetApplicationHomeSubClusterRequest(ApplicationId applicationId) {
     final String cacheKey = buildCacheKey(getClass().getSimpleName(),
-        GET_APPLICATION_HOME_SUBCLUSTER_CACHEID, appId);
+        GET_APPLICATION_HOME_SUBCLUSTER_CACHEID, applicationId.toString());
     CacheRequest<String, SubClusterId> cacheRequest =
         new CacheRequest<>(
             cacheKey,
             input -> {
-              ApplicationId applicationId = ApplicationId.fromString(appId);
-
               GetApplicationHomeSubClusterResponse response =
                   stateStore.getApplicationHomeSubCluster(
                       GetApplicationHomeSubClusterRequest.newInstance(applicationId));
@@ -653,7 +651,7 @@ public Cache<Object, Object> getCache() {
   }
 
   @VisibleForTesting
-  protected Object getAppHomeSubClusterCacheRequest(String appId) {
-    return buildGetApplicationHomeSubClusterRequest(appId);
+  protected Object getAppHomeSubClusterCacheRequest(ApplicationId applicationId) {
+    return buildGetApplicationHomeSubClusterRequest(applicationId);
   }
 }

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/federation/utils/TestFederationStateStoreFacade.java

@@ -226,7 +226,7 @@ public void testGetApplicationHomeSubClusterCache() throws YarnException {
 
     if (isCachingEnabled.booleanValue()) {
       Cache<Object, Object> cache = facade.getCache();
-      Object cacheKey = facade.getAppHomeSubClusterCacheRequest(appId.toString());
+      Object cacheKey = facade.getAppHomeSubClusterCacheRequest(appId);
       Object subClusterIdByCache = cache.get(cacheKey);
       Assert.assertEquals(subClusterIdByFacade, subClusterIdByCache);
       Assert.assertEquals(subClusterId1, subClusterIdByCache);