SummarizedJob Class Improvment

Author: piaoyu

hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/HistoryViewer.java

@@ -602,70 +602,69 @@ public SummarizedJob(JobInfo job) {
         for (JobHistoryParser.TaskAttemptInfo attempt : attempts.values()) {
           long startTime = attempt.getStartTime(); 
           long finishTime = attempt.getFinishTime();
-          if (attempt.getTaskType().equals(TaskType.MAP)) {
+          if (TaskType.MAP.equals(attempt.getTaskType())) {
             if (mapStarted== 0 || mapStarted > startTime) {
               mapStarted = startTime; 
             }
             if (mapFinished < finishTime) {
               mapFinished = finishTime; 
             }
             totalMaps++; 
-            if (attempt.getTaskStatus().equals
-                (TaskStatus.State.FAILED.toString())) {
+            if (TaskStatus.State.FAILED.toString().equals(attempt.getTaskStatus())) {
               numFailedMaps++; 
             } else if (attempt.getTaskStatus().equals
                 (TaskStatus.State.KILLED.toString())) {
               numKilledMaps++;
             }
-          } else if (attempt.getTaskType().equals(TaskType.REDUCE)) {
+          } else if (TaskType.REDUCE.equals(attempt.getTaskType())) {
             if (reduceStarted==0||reduceStarted > startTime) {
               reduceStarted = startTime; 
             }
             if (reduceFinished < finishTime) {
               reduceFinished = finishTime; 
             }
             totalReduces++; 
-            if (attempt.getTaskStatus().equals
-                (TaskStatus.State.FAILED.toString())) {
+            if (TaskStatus.State.FAILED.toString().equals
+                    (attempt.getTaskStatus())) {
               numFailedReduces++; 
-            } else if (attempt.getTaskStatus().equals
-                (TaskStatus.State.KILLED.toString())) {
+            } else if (TaskStatus.State.KILLED.toString().equals
+                (attempt.getTaskStatus())) {
               numKilledReduces++;
             }
-          } else if (attempt.getTaskType().equals(TaskType.JOB_CLEANUP)) {
+          } else if (TaskType.JOB_CLEANUP.equals(attempt.getTaskType())) {
             if (cleanupStarted==0||cleanupStarted > startTime) {
               cleanupStarted = startTime; 
             }
             if (cleanupFinished < finishTime) {
               cleanupFinished = finishTime; 
             }
             totalCleanups++; 
-            if (attempt.getTaskStatus().equals
-                (TaskStatus.State.SUCCEEDED.toString())) {
+            if (TaskStatus.State.SUCCEEDED.toString().equals
+                (attempt.getTaskStatus())) {
               numFinishedCleanups++; 
-            } else if (attempt.getTaskStatus().equals
-                (TaskStatus.State.FAILED.toString())) {
+            } else if (TaskStatus.State.FAILED.toString().equals
+                (attempt.getTaskStatus())) {
               numFailedCleanups++;
-            } else if (attempt.getTaskStatus().equals
-                (TaskStatus.State.KILLED.toString())) {
+            } else if (TaskStatus.State.KILLED.toString().equals
+                (attempt.getTaskStatus())) {
               numKilledCleanups++;
             }
-          } else if (attempt.getTaskType().equals(TaskType.JOB_SETUP)) {
+          } else if (TaskType.JOB_SETUP.equals(attempt.getTaskType())) {
             if (setupStarted==0||setupStarted > startTime) {
               setupStarted = startTime; 
             }
             if (setupFinished < finishTime) {
               setupFinished = finishTime; 
             }
             totalSetups++; 
-            if (attempt.getTaskStatus().equals
-                (TaskStatus.State.SUCCEEDED.toString())) {
+            if (TaskStatus.State.SUCCEEDED.toString().equals
+                (attempt.getTaskStatus())) {
               numFinishedSetups++;
-            } else if (attempt.getTaskStatus().equals
-                (TaskStatus.State.FAILED.toString())) {
+            } else if (TaskStatus.State.FAILED.toString().equals
+                (attempt.getTaskStatus())) {
               numFailedSetups++;
-            } else if (attempt.getTaskStatus().equals
-                (TaskStatus.State.KILLED.toString())) {
+            } else if (TaskStatus.State.KILLED.toString().equals
+                (attempt.getTaskStatus())) {
               numKilledSetups++;
             }
           }