add javadoc

KeeProMise · KeeProMise · commit a934576064a1 · 2023-09-18T14:24:34.000+08:00
diff --git a/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/impl/MembershipStoreImpl.java b/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/impl/MembershipStoreImpl.java
@@ -292,7 +292,7 @@ private MembershipState getRepresentativeQuorum(
     }
 
     // Select largest group
-    Set<MembershipState> largestSet = new TreeSet<>();
+    Set<MembershipState> largestSet = new HashSet<>();
     for (Set<MembershipState> matchingSet : occurenceMap.values()) {
       if (largestSet.size() < matchingSet.size()) {
         largestSet = matchingSet;
diff --git a/hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/store/TestStateStoreMembershipState.java b/hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/store/TestStateStoreMembershipState.java
@@ -223,6 +223,9 @@ public void testRegistrationMajorityQuorum()
     assertEquals(quorumEntry.getRouterId(), ROUTERS[3]);
   }
 
+  /**
+   * Fix getRepresentativeQuorum when records have same date modified time.
+   */
   @Test
   public void testRegistrationMajorityQuorumEqDateModified()
           throws InterruptedException, IOException {

Original file line number	Diff line number	Diff line change
`@@ -292,7 +292,7 @@ private MembershipState getRepresentativeQuorum(`
`292`	`292`	`}`
`293`	`293`
`294`	`294`	`// Select largest group`
`295`		`- Set<MembershipState> largestSet = new TreeSet<>();`
	`295`	`+ Set<MembershipState> largestSet = new HashSet<>();`
`296`	`296`	`for (Set<MembershipState> matchingSet : occurenceMap.values()) {`
`297`	`297`	`if (largestSet.size() < matchingSet.size()) {`
`298`	`298`	`largestSet = matchingSet;`
Original file line number	Diff line number	Diff line change
`@@ -223,6 +223,9 @@ public void testRegistrationMajorityQuorum()`
`223`	`223`	`assertEquals(quorumEntry.getRouterId(), ROUTERS[3]);`
`224`	`224`	`}`
`225`	`225`
	`226`	`+ /**`
	`227`	`+ * Fix getRepresentativeQuorum when records have same date modified time.`
	`228`	`+ */`
`226`	`229`	`@Test`
`227`	`230`	`public void testRegistrationMajorityQuorumEqDateModified()`
`228`	`231`	`throws InterruptedException, IOException {`