Skip to content

Commit a823965

Browse files
committed
more avro related code that needs changes
1 parent e908ea3 commit a823965

File tree

4 files changed

+20
-20
lines changed

4 files changed

+20
-20
lines changed

hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/JobBuilder.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ public class JobBuilder {
8989
private Map<ParsedHost, ParsedHost> allHosts =
9090
new HashMap<ParsedHost, ParsedHost>();
9191

92-
private org.apache.hadoop.mapreduce.jobhistory.JhCounters EMPTY_COUNTERS =
92+
private final static org.apache.hadoop.mapreduce.jobhistory.JhCounters EMPTY_COUNTERS =
9393
new org.apache.hadoop.mapreduce.jobhistory.JhCounters();
9494

9595
/**
@@ -460,7 +460,7 @@ private void processTaskFinishedEvent(TaskFinishedEvent event) {
460460
}
461461
task.setFinishTime(event.getFinishTime());
462462
task.setTaskStatus(getPre21Value(event.getTaskStatus()));
463-
task.incorporateCounters(((TaskFinished) event.getDatum()).counters);
463+
task.incorporateCounters(((TaskFinished) event.getDatum()).getCounters());
464464
}
465465

466466
private void processTaskFailedEvent(TaskFailedEvent event) {
@@ -472,7 +472,7 @@ private void processTaskFailedEvent(TaskFailedEvent event) {
472472
task.setFinishTime(event.getFinishTime());
473473
task.setTaskStatus(getPre21Value(event.getTaskStatus()));
474474
TaskFailed t = (TaskFailed)(event.getDatum());
475-
task.putDiagnosticInfo(t.error.toString());
475+
task.putDiagnosticInfo(t.getError().toString());
476476
// killed task wouldn't have failed attempt.
477477
if (t.getFailedDueToAttempt() != null) {
478478
task.putFailedDueToAttemptId(t.getFailedDueToAttempt().toString());
@@ -542,7 +542,7 @@ private void processTaskAttemptFinishedEvent(TaskAttemptFinishedEvent event) {
542542
}
543543
attempt.setFinishTime(event.getFinishTime());
544544
attempt
545-
.incorporateCounters(((TaskAttemptFinished) event.getDatum()).counters);
545+
.incorporateCounters(((TaskAttemptFinished) event.getDatum()).getCounters());
546546
}
547547

548548
private void processReduceAttemptFinishedEvent(
@@ -568,7 +568,7 @@ private void processReduceAttemptFinishedEvent(
568568
attempt.setShuffleFinished(event.getShuffleFinishTime());
569569
attempt.setSortFinished(event.getSortFinishTime());
570570
attempt
571-
.incorporateCounters(((ReduceAttemptFinished) event.getDatum()).counters);
571+
.incorporateCounters(((ReduceAttemptFinished) event.getDatum()).getCounters());
572572
attempt.arraySetClockSplits(event.getClockSplits());
573573
attempt.arraySetCpuUsages(event.getCpuUsages());
574574
attempt.arraySetVMemKbytes(event.getVMemKbytes());
@@ -596,7 +596,7 @@ private void processMapAttemptFinishedEvent(MapAttemptFinishedEvent event) {
596596
// is redundant, but making this will add future-proofing.
597597
attempt.setFinishTime(event.getFinishTime());
598598
attempt
599-
.incorporateCounters(((MapAttemptFinished) event.getDatum()).counters);
599+
.incorporateCounters(((MapAttemptFinished) event.getDatum()).getCounters());
600600
attempt.arraySetClockSplits(event.getClockSplits());
601601
attempt.arraySetCpuUsages(event.getCpuUsages());
602602
attempt.arraySetVMemKbytes(event.getVMemKbytes());
@@ -661,11 +661,11 @@ private void processJobFinishedEvent(JobFinishedEvent event) {
661661

662662
JobFinished job = (JobFinished)event.getDatum();
663663
Map<String, Long> countersMap =
664-
JobHistoryUtils.extractCounters(job.totalCounters);
664+
JobHistoryUtils.extractCounters(job.getTotalCounters());
665665
result.putTotalCounters(countersMap);
666-
countersMap = JobHistoryUtils.extractCounters(job.mapCounters);
666+
countersMap = JobHistoryUtils.extractCounters(job.getMapCounters());
667667
result.putMapCounters(countersMap);
668-
countersMap = JobHistoryUtils.extractCounters(job.reduceCounters);
668+
countersMap = JobHistoryUtils.extractCounters(job.getReduceCounters());
669669
result.putReduceCounters(countersMap);
670670
}
671671

hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/JobHistoryUtils.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -157,9 +157,9 @@ static boolean isJobConfXml(String fileName) {
157157
static Map<String, Long> extractCounters(JhCounters counters) {
158158
Map<String, Long> countersMap = new HashMap<String, Long>();
159159
if (counters != null) {
160-
for (JhCounterGroup group : counters.groups) {
161-
for (JhCounter counter : group.counts) {
162-
countersMap.put(counter.name.toString(), counter.value);
160+
for (JhCounterGroup group : counters.getGroups()) {
161+
for (JhCounter counter : group.getCounts()) {
162+
countersMap.put(counter.getName().toString(), counter.getValue());
163163
}
164164
}
165165
}

hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/LoggedTask.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -268,11 +268,11 @@ private static void incorporateCounter(SetField thunk, JhCounters counters,
268268
String counterName) {
269269
counterName = canonicalizeCounterName(counterName);
270270

271-
for (JhCounterGroup group : counters.groups) {
272-
for (JhCounter counter : group.counts) {
271+
for (JhCounterGroup group : counters.getGroups()) {
272+
for (JhCounter counter : group.getCounts()) {
273273
if (counterName
274-
.equals(canonicalizeCounterName(counter.name.toString()))) {
275-
thunk.set(counter.value);
274+
.equals(canonicalizeCounterName(counter.getName().toString()))) {
275+
thunk.set(counter.getValue());
276276
return;
277277
}
278278
}

hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/LoggedTaskAttempt.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -636,11 +636,11 @@ private static void incorporateCounter(SetField thunk, JhCounters counters,
636636
String counterName) {
637637
counterName = canonicalizeCounterName(counterName);
638638

639-
for (JhCounterGroup group : counters.groups) {
640-
for (JhCounter counter : group.counts) {
639+
for (JhCounterGroup group : counters.getGroups()) {
640+
for (JhCounter counter : group.getCounts()) {
641641
if (counterName
642-
.equals(canonicalizeCounterName(counter.name.toString()))) {
643-
thunk.set(counter.value);
642+
.equals(canonicalizeCounterName(counter.getName().toString()))) {
643+
thunk.set(counter.getValue());
644644
return;
645645
}
646646
}

0 commit comments

Comments
 (0)