Skip to content

Commit 992f65d

Browse files
committed
YARN-4439. Clarify NMContainerStatus#toString method. Contributed by
Jian He (cherry picked from commit d8a4542)
1 parent 72544db commit 992f65d

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

hadoop-yarn-project/CHANGES.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1129,6 +1129,8 @@ Release 2.7.3 - UNRELEASED
11291129
YARN-4422. Generic AHS sometimes doesn't show started, node, or logs on App page
11301130
(Eric Payne via jeagles)
11311131

1132+
YARN-4439. Clarify NMContainerStatus#toString method. (Jian He via xgong)
1133+
11321134
Release 2.7.2 - UNRELEASED
11331135

11341136
INCOMPATIBLE CHANGES

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/NMContainerStatusPBImpl.java

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,6 @@
3535
import org.apache.hadoop.yarn.proto.YarnServerCommonServiceProtos.NMContainerStatusProtoOrBuilder;
3636
import org.apache.hadoop.yarn.server.api.protocolrecords.NMContainerStatus;
3737

38-
import com.google.protobuf.TextFormat;
39-
4038
public class NMContainerStatusPBImpl extends NMContainerStatus {
4139

4240
NMContainerStatusProto proto = NMContainerStatusProto
@@ -82,7 +80,17 @@ public boolean equals(Object other) {
8280

8381
@Override
8482
public String toString() {
85-
return TextFormat.shortDebugString(getProto());
83+
StringBuilder sb = new StringBuilder();
84+
sb.append("[").append(getContainerId()).append(", ")
85+
.append("CreateTime: ").append(getCreationTime()).append(", ")
86+
.append("State: ").append(getContainerState()).append(", ")
87+
.append("Capability: ").append(getAllocatedResource()).append(", ")
88+
.append("Diagnostics: ").append(getDiagnostics()).append(", ")
89+
.append("ExitStatus: ").append(getContainerExitStatus()).append(", ")
90+
.append("NodeLabelExpression: ").append(getNodeLabelExpression())
91+
.append("Priority: ").append(getPriority())
92+
.append("]");
93+
return sb.toString();
8694
}
8795

8896
@Override

0 commit comments

Comments
 (0)