Skip to content

Commit 7bbee0f

Browse files
committed
addressed review comments
1 parent bcd158f commit 7bbee0f

File tree

8 files changed

+19
-9
lines changed

8 files changed

+19
-9
lines changed

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp/src/test/java/org/apache/hadoop/yarn/appcatalog/application/TestAppCatalogSolrClient.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,18 +22,21 @@
2222
import org.apache.hadoop.yarn.appcatalog.model.AppStoreEntry;
2323
import org.apache.hadoop.yarn.appcatalog.model.Application;
2424
import org.apache.solr.client.solrj.SolrClient;
25+
2526
import org.junit.jupiter.api.AfterEach;
2627
import org.junit.jupiter.api.BeforeEach;
2728
import org.junit.jupiter.api.Test;
29+
2830
import org.mockito.Mockito;
31+
32+
import java.util.List;
33+
2934
import static org.powermock.api.mockito.PowerMockito.when;
3035
import static org.powermock.api.support.membermodification.MemberMatcher.method;
3136

3237
import static org.junit.jupiter.api.Assertions.assertEquals;
3338
import static org.junit.jupiter.api.Assertions.assertTrue;
3439

35-
import java.util.List;
36-
3740
/**
3841
* Unit test for AppCatalogSolrClient.
3942
*/

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/TestCGroupsHandlerImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,13 @@
4242
import java.util.Set;
4343
import java.util.UUID;
4444

45+
import static org.apache.hadoop.test.MockitoUtil.verifyZeroInteractions;
4546
import static org.junit.Assert.assertFalse;
4647
import static org.junit.Assert.assertTrue;
4748
import static org.junit.Assert.fail;
4849
import static org.mockito.ArgumentMatchers.eq;
4950
import static org.mockito.Mockito.verify;
5051
import static org.mockito.Mockito.verifyNoMoreInteractions;
51-
import static org.apache.hadoop.test.MockitoUtil.verifyZeroInteractions;
5252

5353
/**
5454
* Tests for the CGroups handler implementation.

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/TestCGroupsV2HandlerImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@
3737
import java.util.Set;
3838
import java.util.UUID;
3939

40-
import static org.junit.Assert.assertTrue;
4140
import static org.apache.hadoop.test.MockitoUtil.verifyZeroInteractions;
41+
import static org.junit.Assert.assertTrue;
4242

4343
/**
4444
* Tests for the CGroups handler implementation.

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/gpu/TestGpuResourceAllocator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
package org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.gpu;
1818

19+
import static org.apache.hadoop.test.MockitoUtil.verifyZeroInteractions;
1920
import static org.apache.hadoop.yarn.api.records.ResourceInformation.GPU_URI;
2021
import static org.apache.hadoop.yarn.util.resource.CustomResourceTypesConfigurationProvider.initResourceTypes;
2122
import static org.junit.Assert.assertEquals;
@@ -27,7 +28,6 @@
2728
import static org.mockito.Mockito.doThrow;
2829
import static org.mockito.Mockito.mock;
2930
import static org.mockito.Mockito.verify;
30-
import static org.apache.hadoop.test.MockitoUtil.verifyZeroInteractions;
3131
import static org.mockito.Mockito.when;
3232

3333
import java.io.IOException;

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/TestQueuePlacementConverter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,13 @@
1515
*/
1616
package org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.converter;
1717

18+
import static org.apache.hadoop.test.MockitoUtil.verifyZeroInteractions;
1819
import static org.junit.Assert.assertEquals;
1920
import static org.mockito.ArgumentMatchers.eq;
2021
import static org.mockito.ArgumentMatchers.any;
2122
import static org.mockito.Mockito.mock;
2223
import static org.mockito.Mockito.verify;
2324
import static org.mockito.Mockito.verifyNoMoreInteractions;
24-
import static org.apache.hadoop.test.MockitoUtil.verifyZeroInteractions;
2525
import static org.mockito.Mockito.when;
2626

2727
import java.util.List;

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-documentstore/src/test/java/org/apache/hadoop/yarn/server/timelineservice/documentstore/TestDocumentStoreTimelineReaderImpl.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,15 +37,16 @@
3737
import org.apache.hadoop.yarn.server.timelineservice.storage.TimelineReader;
3838
import org.apache.hadoop.yarn.server.timelineservice.documentstore.collection.document.TimelineDocument;
3939
import org.apache.hadoop.yarn.server.timelineservice.documentstore.collection.document.entity.TimelineEntityDocument;
40+
41+
import org.junit.After;
4042
import org.junit.Assert;
4143
import org.junit.Before;
42-
import org.junit.After;
4344
import org.junit.Test;
4445
import org.junit.runner.RunWith;
46+
4547
import org.mockito.ArgumentMatchers;
4648
import org.mockito.MockedStatic;
47-
import static org.mockito.Mockito.mockStatic;
48-
import static org.mockito.Mockito.when;
49+
4950
import org.powermock.core.classloader.annotations.PrepareForTest;
5051
import org.powermock.modules.junit4.PowerMockRunner;
5152

@@ -54,6 +55,8 @@
5455
import java.util.List;
5556
import java.util.Set;
5657

58+
import static org.mockito.Mockito.mockStatic;
59+
import static org.mockito.Mockito.when;
5760

5861
/**
5962
* Test case for {@link DocumentStoreTimelineReaderImpl}.

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-documentstore/src/test/java/org/apache/hadoop/yarn/server/timelineservice/documentstore/TestDocumentStoreTimelineWriterImpl.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,16 @@
2727
import org.apache.hadoop.yarn.server.timelineservice.documentstore.collection.document.TimelineDocument;
2828
import org.apache.hadoop.yarn.server.timelineservice.documentstore.writer.DocumentStoreWriter;
2929
import org.apache.hadoop.yarn.server.timelineservice.documentstore.writer.DummyDocumentStoreWriter;
30+
3031
import org.junit.After;
3132
import org.junit.Before;
3233
import org.junit.Test;
3334
import org.junit.runner.RunWith;
35+
3436
import org.mockito.ArgumentMatchers;
3537
import org.mockito.MockedStatic;
3638
import org.mockito.Mockito;
39+
3740
import org.powermock.api.mockito.PowerMockito;
3841
import org.powermock.core.classloader.annotations.PrepareForTest;
3942
import org.powermock.modules.junit4.PowerMockRunner;

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-documentstore/src/test/java/org/apache/hadoop/yarn/server/timelineservice/documentstore/reader/cosmosdb/TestCosmosDBDocumentStoreReader.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
import org.powermock.api.mockito.PowerMockito;
3131
import org.powermock.core.classloader.annotations.PrepareForTest;
3232
import org.powermock.modules.junit4.PowerMockRunner;
33+
3334
import static org.mockito.Mockito.mockStatic;
3435
import static org.mockito.Mockito.when;
3536

0 commit comments

Comments
 (0)