Revert "HADOOP-17873. ABFS: Fix transient failures in ITestAbfsStream…

…Statistics and ITestAbfsRestOperationException (#3341)" This reverts commit 0379aeb.
apache · Nov 5, 2021 · 7b632dd · 7b632dd
1 parent 689dd7b
commit 7b632dd
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 51 deletions.
diff --git a/hadoop-tools/hadoop-azure/pom.xml b/hadoop-tools/hadoop-azure/pom.xml
@@ -555,7 +555,6 @@
                     <exclude>**/azurebfs/ITestAzureBlobFileSystemListStatus.java</exclude>
                     <exclude>**/azurebfs/extensions/ITestAbfsDelegationTokens.java</exclude>
                     <exclude>**/azurebfs/ITestSmallWriteOptimization.java</exclude>
-                    <exclude>**/azurebfs/ITestAbfsStreamStatistics*.java</exclude>
                     <exclude>**/azurebfs/services/ITestReadBufferManager.java</exclude>
                   </excludes>
 
@@ -598,7 +597,6 @@
                     <include>**/azurebfs/extensions/ITestAbfsDelegationTokens.java</include>
                     <include>**/azurebfs/ITestSmallWriteOptimization.java</include>
                     <include>**/azurebfs/services/ITestReadBufferManager.java</include>
-                    <include>**/azurebfs/ITestAbfsStreamStatistics*.java</include>
                   </includes>
                 </configuration>
               </execution>

diff --git a/...-azure/src/main/java/org/apache/hadoop/fs/azurebfs/oauth2/CustomTokenProviderAdapter.java b/...-azure/src/main/java/org/apache/hadoop/fs/azurebfs/oauth2/CustomTokenProviderAdapter.java
@@ -22,7 +22,6 @@
 import java.io.IOException;
 import java.net.URI;
 
-import org.apache.hadoop.thirdparty.com.google.common.annotations.VisibleForTesting;
 import org.apache.hadoop.thirdparty.com.google.common.base.Preconditions;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -139,9 +138,4 @@ public String getUserAgentSuffix() {
     String suffix = ExtensionHelper.getUserAgentSuffix(adaptee, "");
     return suffix != null ? suffix : "";
   }
-
-  @VisibleForTesting
-  protected CustomTokenProviderAdaptee getCustomTokenProviderAdaptee() {
-    return adaptee;
-  }
 }
diff --git a/...p-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java b/...p-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java
@@ -1223,9 +1223,4 @@ public ListenableFuture<?> submit(Runnable runnable) {
   public <V> void addCallback(ListenableFuture<V> future, FutureCallback<V> callback) {
     Futures.addCallback(future, callback, executorService);
   }
-
-  @VisibleForTesting
-  protected AccessTokenProvider getTokenProvider() {
-    return tokenProvider;
-  }
 }
diff --git a/...hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/AbstractAbfsIntegrationTest.java b/...hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/AbstractAbfsIntegrationTest.java
@@ -37,11 +37,9 @@
 import org.apache.hadoop.fs.Path;
 import org.apache.hadoop.fs.azurebfs.constants.FSOperationType;
 import org.apache.hadoop.fs.azurebfs.contracts.exceptions.AzureBlobFileSystemException;
-import org.apache.hadoop.fs.azurebfs.oauth2.AccessTokenProvider;
 import org.apache.hadoop.fs.azurebfs.security.AbfsDelegationTokenManager;
 import org.apache.hadoop.fs.azurebfs.services.AbfsOutputStream;
 import org.apache.hadoop.fs.azurebfs.services.AuthType;
-import org.apache.hadoop.fs.azurebfs.services.TestAbfsClient;
 import org.apache.hadoop.fs.azure.AzureNativeFileSystemStore;
 import org.apache.hadoop.fs.azure.NativeAzureFileSystem;
 import org.apache.hadoop.fs.azure.metrics.AzureFileSystemInstrumentation;
@@ -241,9 +239,6 @@ public Hashtable<String, String> call() throws Exception {
     }
   }
 
-  public AccessTokenProvider getAccessTokenProvider(final AzureBlobFileSystem fs) {
-    return TestAbfsClient.getAccessTokenProvider(fs.getAbfsStore().getClient());
-  }
 
   public void loadConfiguredFileSystem() throws Exception {
       // disable auto-creation of filesystem

diff --git a/...op-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsRestOperationException.java b/...op-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsRestOperationException.java
@@ -111,21 +111,18 @@ public void testWithDifferentCustomTokenFetchRetry(int numOfRetries) throws Exce
     final AzureBlobFileSystem fs1 =
         (AzureBlobFileSystem) FileSystem.newInstance(fs.getUri(),
         config);
-    RetryTestTokenProvider retryTestTokenProvider
-        = RetryTestTokenProvider.getCurrentRetryTestProviderInstance(
-        getAccessTokenProvider(fs1));
-    retryTestTokenProvider.resetStatusToFirstTokenFetch();
+    RetryTestTokenProvider.ResetStatusToFirstTokenFetch();
 
     intercept(Exception.class,
         ()-> {
           fs1.getFileStatus(new Path("/"));
         });
 
     // Number of retries done should be as configured
-    Assert.assertEquals(
-        "Number of token fetch retries done does not match with fs.azure"
-            + ".custom.token.fetch.retry.count configured", numOfRetries,
-        retryTestTokenProvider.getRetryCount());
+    Assert.assertTrue(
+        "Number of token fetch retries (" + RetryTestTokenProvider.reTryCount
+            + ") done, does not match with fs.azure.custom.token.fetch.retry.count configured (" + numOfRetries
+            + ")", RetryTestTokenProvider.reTryCount == numOfRetries);
   }
 
   @Test

diff --git a/...doop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/oauth2/RetryTestTokenProvider.java b/...doop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/oauth2/RetryTestTokenProvider.java
@@ -30,34 +30,30 @@
  */
 public class RetryTestTokenProvider implements CustomTokenProviderAdaptee {
 
-  private static final Logger LOG = LoggerFactory.getLogger(
-      RetryTestTokenProvider.class);
-
   // Need to track first token fetch otherwise will get counted as a retry too.
-  private boolean isThisFirstTokenFetch = true;
-  private int retryCount = 0;
+  private static boolean isThisFirstTokenFetch = true;
+  public static int reTryCount = 0;
+
+  private static final Logger LOG = LoggerFactory
+      .getLogger(RetryTestTokenProvider.class);
 
   @Override
   public void initialize(Configuration configuration, String accountName)
       throws IOException {
 
   }
 
-  /**
-   * Clear earlier retry details and reset RetryTestTokenProvider instance to
-   * state of first access token fetch call.
-   */
-  public void resetStatusToFirstTokenFetch() {
+  public static void ResetStatusToFirstTokenFetch() {
     isThisFirstTokenFetch = true;
-    retryCount = 0;
+    reTryCount = 0;
   }
 
   @Override
   public String getAccessToken() throws IOException {
     if (isThisFirstTokenFetch) {
       isThisFirstTokenFetch = false;
     } else {
-      retryCount++;
+      reTryCount++;
     }
 
     LOG.debug("RetryTestTokenProvider: Throw an exception in fetching tokens");
@@ -68,13 +64,4 @@ public String getAccessToken() throws IOException {
   public Date getExpiryTime() {
     return new Date();
   }
-
-  public static RetryTestTokenProvider getCurrentRetryTestProviderInstance(
-      AccessTokenProvider customTokenProvider) {
-    return (RetryTestTokenProvider) ((CustomTokenProviderAdapter) customTokenProvider).getCustomTokenProviderAdaptee();
-  }
-
-  public int getRetryCount() {
-    return retryCount;
-  }
 }
diff --git a/...ols/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestAbfsClient.java b/...ols/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestAbfsClient.java
@@ -395,8 +395,4 @@ public static AbfsRestOperation getRestOp(AbfsRestOperationType type,
         url,
         requestHeaders);
   }
-
-  public static AccessTokenProvider getAccessTokenProvider(AbfsClient client) {
-    return client.getTokenProvider();
-  }
 }