diff --git a/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/ArnResource.java b/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/ArnResource.java index 540d2c6b8182b..7c866ac96765d 100644 --- a/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/ArnResource.java +++ b/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/ArnResource.java @@ -26,7 +26,7 @@ /** * Represents an Arn Resource, this can be an accesspoint or bucket. */ -public class ArnResource { +public final class ArnResource { /** * Resource name. diff --git a/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AConfiguration.java b/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AConfiguration.java index ae55f97e9044a..2a6101f47a837 100644 --- a/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AConfiguration.java +++ b/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AConfiguration.java @@ -370,7 +370,7 @@ public void shouldBeAbleToSwitchOnS3PathStyleAccessViaConfigProperty() throw e; } - GenericTestUtils.assertExceptionContains(AP_ILLEGAL_ACCESS , e); + GenericTestUtils.assertExceptionContains(AP_ILLEGAL_ACCESS, e); } } diff --git a/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/S3ATestUtils.java b/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/S3ATestUtils.java index 59639dc44a230..d293db8d35708 100644 --- a/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/S3ATestUtils.java +++ b/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/S3ATestUtils.java @@ -38,7 +38,6 @@ import org.apache.hadoop.fs.s3a.impl.ChangeDetectionPolicy; import org.apache.hadoop.fs.s3a.impl.ContextAccessors; -import org.apache.hadoop.fs.s3a.impl.InternalConstants; import org.apache.hadoop.fs.s3a.impl.StatusProbeEnum; import org.apache.hadoop.fs.s3a.impl.StoreContext; import org.apache.hadoop.fs.s3a.impl.StoreContextBuilder; @@ -264,7 +263,7 @@ private static void skipIfS3GuardAndS3CSEEnabled(Configuration conf) { * @param messages messages found in the PathIOE that trigger a test to skip * @throws PathIOException Throws PathIOE if it doesn't relate to any message in {@code messages}. */ - public static void skipIfIOEContainsMessage(PathIOException ioe, String ...messages) + public static void skipIfIOEContainsMessage(PathIOException ioe, String...messages) throws PathIOException { for (String message: messages) { if (ioe.toString().contains(message)) { diff --git a/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/TestArnResource.java b/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/TestArnResource.java index d8a656962769c..97069c7c8a100 100644 --- a/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/TestArnResource.java +++ b/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/TestArnResource.java @@ -37,9 +37,10 @@ public void parseAccessPointFromArn() throws IllegalArgumentException { String accessPoint = "testAp"; String accountId = "123456789101"; String[][] regionPartitionEndpoints = new String[][] { - { Regions.EU_WEST_1.getName(), "aws", "s3-accesspoint.eu-west-1.amazonaws.com" }, - { Regions.US_GOV_EAST_1.getName(), "aws-us-gov", "s3-accesspoint.us-gov-east-1.amazonaws.com" }, - { Regions.CN_NORTH_1.getName(), "aws-cn", "s3-accesspoint.cn-north-1.amazonaws.com.cn" }, + {Regions.EU_WEST_1.getName(), "aws", "s3-accesspoint.eu-west-1.amazonaws.com"}, + {Regions.US_GOV_EAST_1.getName(), "aws-us-gov", + "s3-accesspoint.us-gov-east-1.amazonaws.com"}, + {Regions.CN_NORTH_1.getName(), "aws-cn", "s3-accesspoint.cn-north-1.amazonaws.com.cn"}, }; for (String[] testPair : regionPartitionEndpoints) {