Skip to content

Commit 41025cd

Browse files
Nargeshdbaajisaka
authored andcommitted
HDFS-16031. Possible Resource Leak in org.apache.hadoop.hdfs.server.aliasmap#InMemoryAliasMap (#3027)
(cherry picked from commit 3fdeb74)
1 parent 48aa23e commit 41025cd

File tree

1 file changed

+7
-13
lines changed
  • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/aliasmap

1 file changed

+7
-13
lines changed

hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/aliasmap/InMemoryAliasMap.java

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -320,21 +320,15 @@ static File createSnapshot(InMemoryAliasMap aliasMap) throws IOException {
320320
private static File getCompressedAliasMap(File aliasMapDir)
321321
throws IOException {
322322
File outCompressedFile = new File(aliasMapDir.getParent(), TAR_NAME);
323-
BufferedOutputStream bOut = null;
324-
GzipCompressorOutputStream gzOut = null;
325-
TarArchiveOutputStream tOut = null;
326-
try {
327-
bOut = new BufferedOutputStream(
328-
Files.newOutputStream(outCompressedFile.toPath()));
329-
gzOut = new GzipCompressorOutputStream(bOut);
330-
tOut = new TarArchiveOutputStream(gzOut);
323+
324+
try (BufferedOutputStream bOut = new BufferedOutputStream(
325+
Files.newOutputStream(outCompressedFile.toPath()));
326+
GzipCompressorOutputStream gzOut = new GzipCompressorOutputStream(bOut);
327+
TarArchiveOutputStream tOut = new TarArchiveOutputStream(gzOut)){
328+
331329
addFileToTarGzRecursively(tOut, aliasMapDir, "", new Configuration());
332-
} finally {
333-
if (tOut != null) {
334-
tOut.finish();
335-
}
336-
IOUtils.cleanupWithLogger(null, tOut, gzOut, bOut);
337330
}
331+
338332
return outCompressedFile;
339333
}
340334

0 commit comments

Comments
 (0)