Skip to content

Commit 20f29f4

Browse files
committed
HADOOP-18468: jettison 1.5.1 (CVE fix)
issues with formatting of json in tests
1 parent 4891bf5 commit 20f29f4

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

LICENSE-binary

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,7 @@ org.apache.kerby:token-provider:2.0.2
343343
org.apache.solr:solr-solrj:8.8.2
344344
org.apache.yetus:audience-annotations:0.5.0
345345
org.apache.zookeeper:zookeeper:3.6.3
346-
org.codehaus.jettison:jettison:1.1
346+
org.codehaus.jettison:jettison:1.5.1
347347
org.eclipse.jetty:jetty-annotations:9.4.48.v20220622
348348
org.eclipse.jetty:jetty-http:9.4.48.v20220622
349349
org.eclipse.jetty:jetty-io:9.4.48.v20220622

hadoop-project/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1498,7 +1498,7 @@
14981498
<dependency>
14991499
<groupId>org.codehaus.jettison</groupId>
15001500
<artifactId>jettison</artifactId>
1501-
<version>1.1</version>
1501+
<version>1.5.1</version>
15021502
<exclusions>
15031503
<exclusion>
15041504
<groupId>stax</groupId>

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesCapacitySched.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@
1818

1919
package org.apache.hadoop.yarn.server.resourcemanager.webapp;
2020

21+
import com.fasterxml.jackson.core.JsonProcessingException;
22+
import com.fasterxml.jackson.databind.ObjectMapper;
2123
import com.google.inject.Guice;
2224
import com.google.inject.servlet.ServletModule;
2325
import com.sun.jersey.api.client.ClientResponse;
@@ -334,7 +336,12 @@ public static void assertJsonResponse(ClientResponse response,
334336
JSONObject json = response.getEntity(JSONObject.class);
335337
String actual = json.toString(2);
336338
updateTestDataAutomatically(expectedResourceFilename, actual);
337-
assertEquals(getResourceAsString(expectedResourceFilename), actual);
339+
assertEquals(prettyPrintJson(getResourceAsString(expectedResourceFilename)), prettyPrintJson(actual));
340+
}
341+
342+
private static String prettyPrintJson(String in) throws JsonProcessingException {
343+
ObjectMapper objectMapper = new ObjectMapper();
344+
return objectMapper.writerWithDefaultPrettyPrinter().writeValueAsString(objectMapper.readTree(in));
338345
}
339346

340347
public static void assertJsonType(ClientResponse response) {

0 commit comments

Comments
 (0)