-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Subtask] Fix duplicate-code Pylint rule for client-python #3767
Comments
I’m interested in working on this issue. I ran an initial pylint test. It looks like there are 20 issues to fix. I will submit them in batches. |
Hi @ian910297, thanks for your interest in this issue. If you have any question, feel free to comment and let us know👍 |
@noidname01 I've outlined some scenarios, but I'd like to discuss them before writing the code.
reference: [SPARK-42342][PYTHON][CONNECT] Introduce base hierarchy to exceptions #39882
|
Hi @ian910297, thanks for your detailed descriptions.
|
Hi @noidname01
I've considered two solutions:
In summary, I believe addressing the duplicated code linting issue is not a priority at this stage. We should focus on reviewing the errors to identify potential architectural improvements. |
@ian910297 I think the reason for Problem 2 is that we use the same test component many times and create them in different files, maybe give them different values can solve the problem? But the problem that every test repeats the same init logic still remains, I think we can move the same logic to parent class (ex. |
Describe the subtask
Parent issue
#3560
The text was updated successfully, but these errors were encountered: