-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement] HiveCatalogOperations.java has no unit tests/code coverage #2185
Comments
@justinmclean i am picking up this one |
How did you discover this issue? I noticed that the code coverage report bot on GitHub is no longer working. Can you please help to address this issue first? |
I just looked at the code coverage report locally. |
@justinmclean i need bit help on this one, specially testing the private methods... i need to understand specially how does the hadoopConf is created. |
@justinmclean can you help me with this? how can i mock or add correct hadoopconf for the test? |
I would test this via mocks. If that is too difficult, either try to test methods that call these private functions or change the code so it is more testable. |
@justinmclean no need to mock, there is existing test which can be extended with correct conf properties to test the private methods. |
Can we fix the code coverage report bot on GitHub first? |
What would you like to be improved?
HiveCatalogOperations.java has no unit tests/code coverage
How should we improve?
Write unit tests to improve code coverage.
The text was updated successfully, but these errors were encountered: