[Improvement] HiveCatalogOperations.java has no unit tests/code coverage

[justinmclean]

What would you like to be improved?

HiveCatalogOperations.java has no unit tests/code coverage

How should we improve?

Write unit tests to improve code coverage.

[ajayl83]

@justinmclean i am picking up this one

[mchades]

How did you discover this issue? I noticed that the code coverage report bot on GitHub is no longer working. Can you please help to address this issue first?

[justinmclean]

I just looked at the code coverage report locally.

[ajayl83]

@justinmclean i need bit help on this one, specially testing the private methods... i need to understand specially how does the hadoopConf is created.

[ajayl83]

@justinmclean can you help me with this? how can i mock or add correct hadoopconf for the test?

[justinmclean]

I would test this via mocks. If that is too difficult, either try to test methods that call these private functions or change the code so it is more testable.

[ajayl83]

@justinmclean no need to mock, there is existing test which can be extended with correct conf properties to test the private methods.

[mchades]

Can we fix the code coverage report bot on GitHub first?