7.0.0-M4 BUG - Unexpected URLMapping Resolution

[codeconsole]

Expected Behavior

This worked fine prior but broke M4. If you have a plugin with a controller, it takes priority over the controller with the same name even if it is in a different namespace IF you run a jar. If you run via bootRun, it works fine.

plugin/grails-app/controllers/UserController

class UserController {
     static namespace = 'myplugin'

     def index() {}
}

grails-app/controllers/UserController

class UserController {
     def index() {}
}

UrlMappings .groovy

"/$controller/$action?/$id?(.$format)?"

grails bootRun
http://localhost/user/index -> grails-app/controllers/UserController.index

grails bootJar
java -jar build/.../sample.jar
http://localhost/user/index ->plugin/grails-app/controllers/UserController.index

Version

7.0.0-M4

[jdaugherty]

I created this branch: https://github.com/apache/grails-core/tree/url-mapping-testing

Added a controller "DuplicateController" in grails-test-examples/app1/.../DuplicateController
Added a controller "DuplicateController" in grails-test-examples/plugins/loadfirst/...DuplicateController

Ran the gradle build:

    ./gradlew build

changed to the libs directory:

    cd grails-test-examples/app1/build/libs

ran the bootJar:

    java -jar grails-test-examples-app1-0.1.jar

Visited: http://localhost:8080/duplicate which shows "app controller" so I can't immediately reproduce this. Can you please provide an application to reproduce it?

In the past these bugs have been because of a bug in the gradle plugin where the groovy compiler script isn't picked up. Is it possible you're still using the older gradle plugins?

Can you look in the plugin build directory, there should be a grailsGroovyCompilerConfig, is there? For example in the branch I created, it has this content for compile:

    withConfig(configuration) {
        inline(phase: 'CONVERSION') { source, context, classNode ->
            classNode.putNodeMetaData('projectVersion', '0.1-SNAPSHOT')
            classNode.putNodeMetaData('projectName', 'grails-test-examples-plugins-loadafter')
            classNode.putNodeMetaData('isPlugin', 'true')
        }
    }

If this script is missing, the behavior described in this ticket would exist.

[codeconsole]

@jdaugherty this issue is actually much deeper and no long think it has to do with UrlMappings

grailsApplication.getArtefactByLogicalPropertyName('Controller', 'user') is not returning the primary controller and is resolving the controller in the plugin. In your example, did you have your default controller in a package?

[jdaugherty]

Please provide an example project

[jdaugherty]

Hi @codeconsole were you able to generate an example project for this issue?

[codeconsole]

Unfortunately, at this point, it seems random perhaps based on startup class loading order. If I run multiple instances of the same jar, I get different behavior.

Specifically

grailsApplication.getArtefactByLogicalPropertyName('Controller', 'match').namespace

Running the following against a cluster:

[grailsApplication.metadata['info.app.version'], grailsApplication.metadata['info.app.grailsVersion'], InetAddress.getLocalHost(), grailsApplication.getArtefactByLogicalPropertyName('Controller', 'match').namespace]

results in

['5.6.7', '7.0.0-M4', cf422e86f7bd/172.17.0.2, null]
[40 ms]
≫
['5.6.7', '7.0.0-M4', cf422e86f7bd/172.17.0.2, null]
[39 ms]
≫
['5.6.7', '7.0.0-M4', b12b6a85f0b9/172.17.0.2, 'bq']
[40 ms]
≫
['5.6.7', '7.0.0-M4', bbf6c0b581df/172.17.0.2, 'bq']
[40 ms]

[codeconsole]

I believe this is a result of class loading order that changed in M4.

Example App: https://github.com/codeconsole/namespacebug

grails-core/grails-core/src/main/groovy/grails/core/DefaultGrailsApplication.java

Lines 770 to 773 in 1ed250d

	public GrailsClass getArtefactByLogicalPropertyName(String type, String logicalName) {
	ArtefactInfo info = getArtefactInfo(type);
	return info == null ? null : info.getGrailsClassByLogicalPropertyName(logicalName);
	}

grails-core/grails-core/src/main/groovy/grails/core/DefaultArtefactInfo.java

Lines 115 to 117 in 1ed250d

	public GrailsClass getGrailsClassByLogicalPropertyName(String logicalName) {
	return logicalPropertyNameToClassMap.get(logicalName);
	}

grails-core/grails-core/src/main/groovy/grails/boot/config/GrailsApplicationPostProcessor.groovy

Lines 123 to 132 in 1ed250d

	protected void performGrailsInitializationSequence() {
	pluginManager.doArtefactConfiguration()
	grailsApplication.initialise()
	// register plugin provided classes first, this gives the oppurtunity
	// for application classes to override those provided by a plugin
	pluginManager.registerProvidedArtefacts(grailsApplication)
	for(cls in classes) {
	grailsApplication.addArtefact(cls)
	}
	}