Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-23861][sql-client]flink sql client support dynamic params #16877

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zhangbinzaifendou
Copy link

@zhangbinzaifendou zhangbinzaifendou commented Aug 18, 2021

What is the purpose of the change

1 Every time the set command is executed, the method call process is very long and a new createTableEnvironment object is created

2 As a result of the previous discussion in https://issues.apache.org/jira/browse/FLINK-22770, I don't think it's a good habit for users to put quotes around keys and values.

Brief change log

./bin/sql-client.sh -i conf/init.sql -c execution.runtime-mode=batch -c yarn.application.name="test" -f sql/q1.sql -c sql-client.execution.result-mode=TABLEAU -c execution.target=yarn-per-job
-c k=v does not need to create a new createTableEnvironment object

This way of using single quotes like set 'k'='v' may make users feel a bit out of place compared to other systems (Spark, Hive)

Verifying this change

CliOptions.java
CliOptionsParser.java
SqlClient.java

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: Jno
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? yes(Only the flink SQL Client functionality has been enhanced)
  • If yes, how is the feature documented? docs

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 7bab505 (Wed Aug 18 12:36:47 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!
  • Invalid pull request title: No valid Jira ID provided

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 18, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@zhangbinzaifendou zhangbinzaifendou changed the title flink sql client support dynamic params [FLINK-23861][sql-client]flink sql client support dynamic params Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants