[FLINK-23861][sql-client]flink sql client support dynamic params #16877
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
1 Every time the set command is executed, the method call process is very long and a new createTableEnvironment object is created
2 As a result of the previous discussion in https://issues.apache.org/jira/browse/FLINK-22770, I don't think it's a good habit for users to put quotes around keys and values.
Brief change log
./bin/sql-client.sh -i conf/init.sql -c execution.runtime-mode=batch -c yarn.application.name="test" -f sql/q1.sql -c sql-client.execution.result-mode=TABLEAU -c execution.target=yarn-per-job
-c k=v does not need to create a new createTableEnvironment object
This way of using single quotes like set 'k'='v' may make users feel a bit out of place compared to other systems (Spark, Hive)
Verifying this change
CliOptions.java
CliOptionsParser.java
SqlClient.java
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation