[FELIX-6066] Prevent duplicate activation of ConfigurationManager #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cziegeler
reviewed
Feb 21, 2019
Contributor
cziegeler
left a comment
cziegeler
left a comment
There was a problem hiding this comment.
Thanks for the PR, looks good to me. What about moving the call to setActivated into the activate() method?
grgrzybek
force-pushed
the
FELIX-6066-ggrzybek
branch
from
10b1b03 to
1e41028
Compare
Author
|
sure - it's after all not a setter. I updated the PR. |
asfgit
pushed a commit
that referenced
this pull request
Nov 6, 2019
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1854973 13f79535-47bb-0310-9956-ffa450edef68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.